Browser Plugin: Implement BrowserPluginObserver.

content/renderer/browser_plugin/browser_plugin_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_MANAGER_H_
 #define CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_MANAGER_H_
 
 #include "base/id_map.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/observer_list.h"
 #include "content/public/renderer/render_view_observer.h"
 #include "ipc/ipc_sender.h"
 
 namespace WebKit {
 class WebFrame;
 struct WebPluginParams;
 }
 
 namespace content {
 
-class BrowserPlugin;
+class BrowserPluginImpl;
 class BrowserPluginManagerFactory;
 class RenderViewImpl;
 
 // BrowserPluginManager manages the routing of messages to the appropriate
 // BrowserPlugin object based on its instance ID.
 class CONTENT_EXPORT BrowserPluginManager
     : public RenderViewObserver,
       public base::RefCounted<BrowserPluginManager> {
  public:
   // Returns the one BrowserPluginManager for this process.
   static BrowserPluginManager* Create(RenderViewImpl* render_view);
 
   // Overrides factory for testing. Default (NULL) value indicates regular
   // (non-test) environment.
   static void set_factory_for_testing(BrowserPluginManagerFactory* factory) {
     BrowserPluginManager::factory_ = factory;
   }
 
   BrowserPluginManager(RenderViewImpl* render_view);
 
   // Creates a new BrowserPlugin object with a unique identifier.
   // BrowserPlugin is responsible for associating itself with the
   // BrowserPluginManager via AddBrowserPlugin. When it is destroyed, it is
   // responsible for removing its association via RemoveBrowserPlugin.
-  virtual BrowserPlugin* CreateBrowserPlugin(
+  virtual BrowserPluginImpl* CreateBrowserPlugin(
       RenderViewImpl* render_view,
       WebKit::WebFrame* frame,
       const WebKit::WebPluginParams& params) = 0;
 
-  void AddBrowserPlugin(int instance_id, BrowserPlugin* browser_plugin);
+  void AddBrowserPlugin(int instance_id, BrowserPluginImpl* browser_plugin);
   void RemoveBrowserPlugin(int instance_id);
-  BrowserPlugin* GetBrowserPlugin(int instance_id) const;
+  BrowserPluginImpl* GetBrowserPlugin(int instance_id) const;
   void SetEmbedderFocus(const RenderViewImpl* embedder, bool focused);
   RenderViewImpl* render_view() const { return render_view_; }
 
+  void RequestMessage(uint32 message_id);

[sadrul, 2013/01/09 15:21:54]

doc

[Fady Samuel, 2013/01/09 17:41:24]

Done.

+
   // RenderViewObserver implementation.
 
   // BrowserPluginManager must override the default Send behavior.
   virtual bool Send(IPC::Message* msg) OVERRIDE = 0;
 
   // Don't destroy the BrowserPluginManager when the RenderViewImpl goes away.
   // BrowserPluginManager's lifetime is managed by a reference count. Once
   // the host RenderViewImpl and all BrowserPlugins release their references,
   // then the BrowserPluginManager will be destroyed.
   virtual void OnDestruct() OVERRIDE {}
 
  protected:
   // Friend RefCounted so that the dtor can be non-public.
   friend class base::RefCounted<BrowserPluginManager>;
 
+

[sadrul, 2013/01/09 15:21:54]

too many new lines

[Fady Samuel, 2013/01/09 17:41:24]

Done.

+  // Returns whether a message should be forwarded to BrowserPlugins.
+  bool ShouldForwardToBrowserPlugin(const IPC::Message& message);
+
   // Static factory instance (always NULL for non-test).
   static BrowserPluginManagerFactory* factory_;
 
   virtual ~BrowserPluginManager();
-  IDMap<BrowserPlugin> instances_;
+  IDMap<BrowserPluginImpl> instances_;
   base::WeakPtr<RenderViewImpl> render_view_;
   int browser_plugin_counter_;
+  // Set of messages requested by BrowserPluginObservers.
+  std::set<uint32> browser_plugin_messages_;
 };

[sadrul, 2013/01/09 15:21:54]

You should have a DISALLOW_COPY_AND_ASSIGN inside a private block here.

[Fady Samuel, 2013/01/09 17:41:24]

Done.

 
 }  // namespace content
 
 #endif //  CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_MANAGER_H_