Reject invalid GURLs across IPC.

Reject invalid GURLs across IPC.

Also add some per-file owners to the common_param_traits.cc, since it's a
highly security-sensitive area.

BUG=168923
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176009

[Chris Evans, 2013-01-09 01:37:19]

@jam: for the test change, which is under chrome/ (creis@ is not an owner)
@creis: for  the content/ changes.

[Chris Evans, 2013-01-09 01:37:58]

On 2013/01/09 01:37:19, Chris Evans wrote:
> @jam: for the test change, which is under chrome/ (creis@ is not an owner)
> @creis: for  the content/ changes.

FWIW, passes a try run.

[Charlie Reis, 2013-01-09 02:22:10]

I'm pretty sure I don't understand the implications of this change.  Brett, can
you review common_param_traits.cc, since you looked at
https://chromiumcodereview.appspot.com/11576038/?

[Chris Evans, 2013-01-09 03:22:59]

On 2013/01/09 02:22:10, creis wrote:
> I'm pretty sure I don't understand the implications of this change.  Brett,
can
> you review common_param_traits.cc, since you looked at
> https://chromiumcodereview.appspot.com/11576038/?

Thanks, Charlie.

If it helps, I did add some DCHECKs across a full test run to see if anything is
relying on passing GURLs in a bad state across the IPC. Seems we're pretty clean
-- that's what I would have hoped :)

[jam, 2013-01-09 16:50:21]

lgtm

https://codereview.chromium.org/11826002/diff/8005/chrome/common/common_param...
File chrome/common/common_param_traits_unittest.cc (right):

https://codereview.chromium.org/11826002/diff/8005/chrome/common/common_param...
chrome/common/common_param_traits_unittest.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
oh, i didn't know about this test (or forgot about it). anyway you can move it
to content/common?

https://codereview.chromium.org/11826002/diff/8005/content/public/common/OWNERS
File content/public/common/OWNERS (right):

https://codereview.chromium.org/11826002/diff/8005/content/public/common/OWNE...
content/public/common/OWNERS:3: per-file
common_param_traits.cc=creis@chromium.org
creis is an owner for src/content, so don't add him here

[Chris Evans, 2013-01-10 00:38:25]

On 2013/01/09 16:50:21, John Abd-El-Malek wrote:
> lgtm

(Chatted with John in the corridor and confirmed that the LGTM is for the whole
CL. Fixing points below and landing):

> 
>
https://codereview.chromium.org/11826002/diff/8005/chrome/common/common_param...
> File chrome/common/common_param_traits_unittest.cc (right):
> 
>
https://codereview.chromium.org/11826002/diff/8005/chrome/common/common_param...
> chrome/common/common_param_traits_unittest.cc:1: // Copyright (c) 2012 The
> Chromium Authors. All rights reserved.
> oh, i didn't know about this test (or forgot about it). anyway you can move it
> to content/common?

Moved.

> 
>
https://codereview.chromium.org/11826002/diff/8005/content/public/common/OWNERS
> File content/public/common/OWNERS (right):
> 
>
https://codereview.chromium.org/11826002/diff/8005/content/public/common/OWNE...
> content/public/common/OWNERS:3: per-file
> mailto:common_param_traits.cc=creis@chromium.org
> creis is an owner for src/content, so don't add him here

Removed.