Reject invalid GURLs across IPC.

chrome/common/common_param_traits_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

[jam, 2013/01/09 16:50:21]

oh, i didn't know about this test (or forgot about it). anyway you can move it
to content/common?

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 #include <utility>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "content/public/common/common_param_traits.h"
 #include "googleurl/src/gurl.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_message_utils.h"
 #include "net/base/host_port_pair.h"
 #include "printing/backend/print_backend.h"
 #include "printing/page_range.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/rect.h"
 
 // Tests that serialize/deserialize correctly understand each other
 TEST(IPCMessageTest, Serialize) {
   const char* serialize_cases[] = {
     "http://www.google.com/",
     "http://user:pass@host.com:888/foo;bar?baz#nop",
-    "#inva://idurl/",
   };
 
   for (size_t i = 0; i < arraysize(serialize_cases); i++) {
     GURL input(serialize_cases[i]);
     IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
     IPC::ParamTraits<GURL>::Write(&msg, input);
 
     GURL output;
     PickleIterator iter(msg);
     EXPECT_TRUE(IPC::ParamTraits<GURL>::Read(&msg, &iter, &output));
 
     // We want to test each component individually to make sure its range was
     // correctly serialized and deserialized, not just the spec.
     EXPECT_EQ(input.possibly_invalid_spec(), output.possibly_invalid_spec());
     EXPECT_EQ(input.is_valid(), output.is_valid());
     EXPECT_EQ(input.scheme(), output.scheme());
     EXPECT_EQ(input.username(), output.username());
     EXPECT_EQ(input.password(), output.password());
     EXPECT_EQ(input.host(), output.host());
     EXPECT_EQ(input.port(), output.port());
     EXPECT_EQ(input.path(), output.path());
     EXPECT_EQ(input.query(), output.query());
     EXPECT_EQ(input.ref(), output.ref());
   }
 
+  // Test an invalid GURL.
+  {
+    IPC::Message msg;
+    msg.WriteString("#inva://idurl/");
+    GURL output;
+    PickleIterator iter(msg);
+    EXPECT_FALSE(IPC::ParamTraits<GURL>::Read(&msg, &iter, &output));
+  }
+
   // Also test the corrupt case.
   IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
   msg.WriteInt(99);
   GURL output;
   PickleIterator iter(msg);
   EXPECT_FALSE(IPC::ParamTraits<GURL>::Read(&msg, &iter, &output));
 }
 
 // Tests std::pair serialization
 TEST(IPCMessageTest, Pair) {
@@ skipping 115 matching lines @@
 
   IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
   IPC::ParamTraits<net::HostPortPair>::Write(&msg, input);
 
   net::HostPortPair output;
   PickleIterator iter(msg);
   EXPECT_TRUE(IPC::ParamTraits<net::HostPortPair>::Read(&msg, &iter, &output));
   EXPECT_EQ(input.host(), output.host());
   EXPECT_EQ(input.port(), output.port());
 }