Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 1182583003: Simply download_from_google_storage --config (Closed)

5 years, 6 months ago by hinoka
5 years, 6 months ago
Vadim Sh.
chromium-reviews,,, Peter Mayo
Target Ref:


Simply download_from_google_storage --config This does two noticable things: * Prints a message when "download_from_google_storage --config" is run to tell the user to enter "0" for the project ID prompt * Removes the ".boto.depot_tools" boto file and defaults the boto file to grant fullcontrol scopes. Context: We restricted the depot_tools specific scopes to be readonly out of concern that we would be forcing every developer to hold a set of non-expiring write access credentials on their workstation. But this distinction has caused a great deal of pain and anguish with confusing credentials (who would've thought ~/.boto.depot_tools would exist and might be broken?), and not for huge security gains. Most people don't have write access to buckets, and the ones that do definitely has a fullcontrol boto file already. BUG= Committed:

Patch Set 1 #

Total comments: 2

Patch Set 2 : keep os.devnull boto, don't use execv #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M View 1 3 chunks +6 lines, -8 lines 1 comment Download


Total messages: 8 (2 generated)
+vadimsh for review to see if security justification seems sound +petermayo fyi about the boto.depot_tools
5 years, 6 months ago (2015-06-17 17:33:44 UTC) #2
Vadim Sh.
IIUC, it will require existing users of download_from_google_storage to rerun config again? (Since boto file ...
5 years, 6 months ago (2015-06-17 19:24:04 UTC) #3
Yes I'll be sending a PSA to chromium-dev first. File (right): ...
5 years, 6 months ago (2015-06-17 19:49:20 UTC) #4
Vadim Sh.
5 years, 6 months ago (2015-06-17 20:29:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at
5 years, 6 months ago (2015-06-17 20:34:52 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 20:37:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as

Powered by Google App Engine
This is Rietveld 408576698