Removes TextInputFocusManager.

Removes TextInputFocusManager.

TextInputFocusManager can be removed with the effort of IMF refactoring.
Actually the bugs that TextInputFocusManager was trying to fix have been fixed
already by IMF refactoring.

TBR=sky@chromium.org
BUG=474828
TEST=Trybots.

Committed: https://crrev.com/4e09795ae7eaacce866f0de33a0c9a3c89e4464e
Cr-Commit-Position: refs/heads/master@{#334379}

[Shu Chen, 2015-06-15 02:46:48]

shuchen@chromium.org changed reviewers:
+ yukawa@chromium.org, yukishiino@chromium.org

[Shu Chen, 2015-06-15 02:46:49]

Yohei/Yuki, can you please review this cl? Thanks

[yukawa, 2015-06-15 02:50:23]

LGTM but please wait for Yuki's comment.

Looks purely mechanical and safe enough to me.

[Yuki, 2015-06-15 04:34:29]

https://codereview.chromium.org/1182523003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc (left):

https://codereview.chromium.org/1182523003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc:378:
IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, FocusedTextInputClient) {
I think we want to pass this test regardless of what the code we're running.
Please remove only the hack for TestInputFocusManager, and try to pass the test
to confirm that Omnibox gets focused in terms of text input.

[Shu Chen, 2015-06-15 05:06:49]

https://codereview.chromium.org/1182523003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc (left):

https://codereview.chromium.org/1182523003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc:378:
IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, FocusedTextInputClient) {
On 2015/06/15 04:34:29, Yuki wrote:
> I think we want to pass this test regardless of what the code we're running.
> Please remove only the hack for TestInputFocusManager, and try to pass the
test
> to confirm that Omnibox gets focused in terms of text input.

Done.

[Yuki, 2015-06-15 06:14:31]

lgtm

https://codereview.chromium.org/1182523003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc (right):

https://codereview.chromium.org/1182523003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc:385:
EXPECT_EQ(omnibox_view_views, input_method->GetTextInputClient());
nit: better explicitly write as:
  omnibox_view_views->GetTextInputClient()

IIRC, OmniboxViewViews inherits TextInputClient directly, but it seems
implementation-based decision rather than design decision.  Considering their
nature, OmniboxViewViews is views:View, and not necessarily be TextInputClient
itself.

[Shu Chen, 2015-06-15 06:24:35]

https://codereview.chromium.org/1182523003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc (right):

https://codereview.chromium.org/1182523003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc:385:
EXPECT_EQ(omnibox_view_views, input_method->GetTextInputClient());
On 2015/06/15 06:14:30, Yuki wrote:
> nit: better explicitly write as:
>   omnibox_view_views->GetTextInputClient()
> 
> IIRC, OmniboxViewViews inherits TextInputClient directly, but it seems
> implementation-based decision rather than design decision.  Considering their
> nature, OmniboxViewViews is views:View, and not necessarily be TextInputClient
> itself.

Done.

[Shu Chen, 2015-06-15 06:24:41]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2015-06-15 06:24:42]

The patchset sent to the CQ was uploaded after l-g-t-m from yukawa@chromium.org,
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/1182523003/#ps60001
(title: "nit per comment.")

[commit-bot: I haz the power, 2015-06-15 06:24:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182523003/60001

[Shu Chen, 2015-06-15 06:25:30]

+TBR=sky@ for only rubber stamp.

[commit-bot: I haz the power, 2015-06-15 08:16:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-15 08:16:02]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Shu Chen, 2015-06-15 09:10:45]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2015-06-15 09:10:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182523003/60001

[commit-bot: I haz the power, 2015-06-15 09:58:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-15 09:58:46]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Shu Chen, 2015-06-15 10:10:57]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2015-06-15 10:11:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182523003/60001

[commit-bot: I haz the power, 2015-06-15 11:38:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-15 11:38:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Shu Chen, 2015-06-15 12:47:42]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2015-06-15 12:48:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182523003/60001

[commit-bot: I haz the power, 2015-06-15 14:14:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-15 14:14:12]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Shu Chen, 2015-06-15 14:14:49]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2015-06-15 14:15:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182523003/60001

[commit-bot: I haz the power, 2015-06-15 15:07:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-15 15:09:19]

Patchset 4 (id:??) landed as
https://crrev.com/4e09795ae7eaacce866f0de33a0c9a3c89e4464e
Cr-Commit-Position: refs/heads/master@{#334379}