Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: ui/views/widget/widget.cc

Issue 1182523003: Removes TextInputFocusManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit per comment. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/native_widget_aura.cc ('k') | ui/wm/core/focus_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget.cc
diff --git a/ui/views/widget/widget.cc b/ui/views/widget/widget.cc
index 7f8e0761e08730305f9ebe1c59806df7692e0612..a57392053e57788faee01af110c585c0e82ea404 100644
--- a/ui/views/widget/widget.cc
+++ b/ui/views/widget/widget.cc
@@ -1051,19 +1051,6 @@ void Widget::OnNativeWidgetActivationChanged(bool active) {
FOR_EACH_OBSERVER(WidgetObserver, observers_,
OnWidgetActivationChanged(this, active));
- // During window creation, the widget gets focused without activation, and in
- // that case, the focus manager cannot set the appropriate text input client
- // because the widget is not active. Thus we have to notify the focus manager
- // not only when the focus changes but also when the widget gets activated.
- // See crbug.com/377479 for details.
- views::FocusManager* focus_manager = GetFocusManager();
- if (focus_manager) {
- if (active)
- focus_manager->FocusTextInputClient(focus_manager->GetFocusedView());
- else
- focus_manager->BlurTextInputClient(focus_manager->GetFocusedView());
- }
-
if (IsVisible() && non_client_view())
non_client_view()->frame_view()->SchedulePaint();
}
« no previous file with comments | « ui/views/widget/native_widget_aura.cc ('k') | ui/wm/core/focus_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698