Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8536)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1182423004: Adding UMA stat when generated password set for newly created PasswordFormManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 2df5a91b1fa506c94c2061e5083577322c745c76..219c1571c065f07d91639dfa1df2b08368010619 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -170,7 +170,8 @@ void PasswordManager::SetHasGeneratedPasswordForForm(
this, client_, driver->AsWeakPtr(), form, ssl_valid);
pending_login_managers_.push_back(manager);
manager->set_has_generated_password(true);
- // TODO(gcasto): Add UMA stats to track this.
+ UMA_HISTOGRAM_BOOLEAN("PasswordManager.SetGeneratedPasswordForForm",
Garrett Casto 2015/06/22 23:23:57 The name should be something like "PasswordManager
Deepak 2015/06/23 06:23:16 Done.
+ password_is_generated);
}
void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698