Adding UMA stat when generated password set for newly created PasswordFormManager.

components/password_manager/core/browser/password_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_manager.h"
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/prefs/pref_service.h"
@@ skipping 138 matching lines @@
   DCHECK(client_->IsSavingEnabledForCurrentPage());
 
   for (ScopedVector<PasswordFormManager>::iterator iter =
            pending_login_managers_.begin();
        iter != pending_login_managers_.end(); ++iter) {
     if ((*iter)->DoesManage(form) ==
         PasswordFormManager::RESULT_COMPLETE_MATCH) {
       (*iter)->set_has_generated_password(password_is_generated);
       return;
     }
   }

[Garrett Casto, 2015/06/22 23:23:57]

For completeness, this loop here should actually be the same as the loop in
ProvisionallySavePassword(). It's unlikely that this function will be triggered
where there isn't a perfect match, but it's possible.

[Deepak, 2015/06/23 06:23:16]

Done.

 
   if (!password_is_generated) {
     return;
   }
 
   // If there is no corresponding PasswordFormManager, we create one. This is
   // not the common case, and should only happen when there is a bug in our
   // ability to detect forms.
   bool ssl_valid = form.origin.SchemeIsCryptographic();
   PasswordFormManager* manager = new PasswordFormManager(
       this, client_, driver->AsWeakPtr(), form, ssl_valid);
   pending_login_managers_.push_back(manager);
   manager->set_has_generated_password(true);
-  // TODO(gcasto): Add UMA stats to track this.
+  UMA_HISTOGRAM_BOOLEAN("PasswordManager.SetGeneratedPasswordForForm",

[Garrett Casto, 2015/06/22 23:23:57]

The name should be something like
"PasswordManager.GeneratedFormHasNoFormManager". It also should be called before
line 161, as |password_is_generated| will always be true at this point.

[Deepak, 2015/06/23 06:23:16]

Done.

+                        password_is_generated);
 }
 
 void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
   bool is_saving_enabled = client_->IsSavingEnabledForCurrentPage();
 
   scoped_ptr<BrowserSavePasswordProgressLogger> logger;
   if (client_->IsLoggingActive()) {
     logger.reset(new BrowserSavePasswordProgressLogger(client_));
     logger->LogMessage(Logger::STRING_PROVISIONALLY_SAVE_PASSWORD_METHOD);
     logger->LogPasswordForm(Logger::STRING_PROVISIONALLY_SAVE_PASSWORD_FORM,
@@ skipping 520 matching lines @@
       if (ServerTypeToPrediction((*field)->server_type(), &prediction_type))
         predictions[form->ToFormData()][prediction_type] = *(*field);
     }
   }
   if (predictions.empty())
     return;
   driver->AutofillDataReceived(predictions);
 }
 
 }  // namespace password_manager