Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 11824045: Get GpuCrashTest running in content_browsertests. (Closed)

Created:
7 years, 11 months ago by Zhenyao Mo
Modified:
7 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Get GpuCrashTest running in content_browsertests. 1) The test class name should begin with "Gpu" to be picked by gpu bot filters. 2) implify gpu crash tests by directly call the SimulateCrash function. Before we open a new tab, go to about:gpucrash. This is really unnecessary. 3) Disable infobar stuff for Kill - otherwise the GPU process won't launch after crashing. 4) Clean up the webgl.html a little bit. BUG=111506 TEST=gpu bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175933

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -42 lines) Patch
M content/browser/gpu/gpu_crash_browsertest.cc View 1 3 chunks +12 lines, -28 lines 0 comments Download
M content/test/data/gpu/webgl.html View 1 2 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Zhenyao Mo
Ken: please have a look. Once this runs fine in content_browsertests, I will remove the ...
7 years, 11 months ago (2013-01-09 23:12:50 UTC) #1
Ken Russell (switch to Gerrit)
LGTM There's one new test in src/chrome/test/gpu/gpu_crash_browsertest.cc (GPUCrashTest.ContextLossRaisesInfobar) which I'd like to preserve if at ...
7 years, 11 months ago (2013-01-09 23:59:03 UTC) #2
Zhenyao Mo
7 years, 11 months ago (2013-01-10 00:02:47 UTC) #3
On 2013/01/09 23:59:03, kbr wrote:
> LGTM
> 
> There's one new test in src/chrome/test/gpu/gpu_crash_browsertest.cc
> (GPUCrashTest.ContextLossRaisesInfobar) which I'd like to preserve if at all
> possible. Maybe we can add our own WebContentsObserver overriding
DidBlock3DAPIs
> and ensure that that method is called against it after calling
SimulateGPUCrash?
> This doesn't have to be done in this CL.

Sure.  When I said I would remove the chrome side tests, I wasn't planning to
remove the WebGL infobar tests.

Powered by Google App Engine
This is Rietveld 408576698