Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: content/browser/gpu/gpu_crash_browsertest.cc

Issue 11824045: Get GpuCrashTest running in content_browsertests. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/data/gpu/webgl.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_crash_browsertest.cc
===================================================================
--- content/browser/gpu/gpu_crash_browsertest.cc (revision 175856)
+++ content/browser/gpu/gpu_crash_browsertest.cc (working copy)
@@ -2,40 +2,21 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "base/command_line.h"
-#include "base/memory/scoped_ptr.h"
#include "base/path_service.h"
-#include "base/utf_string_conversions.h"
+#include "content/browser/gpu/gpu_data_manager_impl.h"
+#include "content/browser/gpu/gpu_process_host_ui_shim.h"
#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
#include "content/public/common/content_paths.h"
-#include "content/public/common/url_constants.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/test_utils.h"
#include "content/shell/shell.h"
#include "content/test/content_browser_test.h"
#include "content/test/content_browser_test_utils.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "ui/gl/gl_implementation.h"
-namespace {
-
-void SimulateGPUCrash(content::Shell* s) {
- LOG(ERROR) << "SimulateGPUCrash, before LoadURL";
- s->LoadURL(GURL(chrome::kChromeUIGpuCrashURL));
- LOG(ERROR) << "SimulateGPUCrash, after LoadURL";
-}
-
-} // namespace
-
namespace content {
-class GPUCrashTest : public ContentBrowserTest {
+class GpuCrashTest : public ContentBrowserTest {
protected:
- virtual void SetUpCommandLine(CommandLine* command_line) {
- // GPU tests require gpu acceleration.
- // We do not care which GL backend is used.
- command_line->AppendSwitchASCII(switches::kUseGL, "any");
- }
virtual void SetUpInProcessBrowserTestFixture() {
FilePath test_dir;
ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &test_dir));
@@ -44,10 +25,12 @@
FilePath gpu_test_dir_;
};
-// Currently Kill times out on GPU bots: http://crbug.com/101513
-IN_PROC_BROWSER_TEST_F(GPUCrashTest, MANUAL_Kill) {
+IN_PROC_BROWSER_TEST_F(GpuCrashTest, MANUAL_Kill) {
DOMMessageQueue message_queue;
+ content::GpuDataManagerImpl::GetInstance()->
+ DisableDomainBlockingFor3DAPIsForTesting();
+
// Load page and wait for it to load.
content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
@@ -58,16 +41,17 @@
gpu_test_dir_.AppendASCII("webgl.html"), "query=kill"));
observer.Wait();
- scoped_ptr<Shell> shell(CreateBrowser());
- SimulateGPUCrash(shell.get());
+ GpuProcessHostUIShim* host =
+ GpuProcessHostUIShim::GetOneInstance();
+ ASSERT_TRUE(host);
+ host->SimulateCrash();
std::string m;
ASSERT_TRUE(message_queue.WaitForMessage(&m));
EXPECT_EQ("\"SUCCESS\"", m);
}
-
-IN_PROC_BROWSER_TEST_F(GPUCrashTest, MANUAL_WebkitLoseContext) {
+IN_PROC_BROWSER_TEST_F(GpuCrashTest, MANUAL_WebkitLoseContext) {
DOMMessageQueue message_queue;
NavigateToURL(
« no previous file with comments | « no previous file | content/test/data/gpu/webgl.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698