Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 11824036: Update #includes (and some comments) since WebKitPlatformSupport class is now defined in Platform.h… (Closed)

Created:
7 years, 11 months ago by pilgrim_google
Modified:
7 years, 10 months ago
Reviewers:
jamesr, sky
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Update #includes (and some comments) since WebKitPlatformSupport class is now defined in Platform.h upstream Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183905

Patch Set 1 #

Patch Set 2 : Update some #includes now that WebKitPlatformSupport is defined in Platform.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/public/test/unittest_test_suite.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/cpp_bound_class_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M webkit/glue/webkitplatformsupport_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
pilgrim_google
Update some #includes now that WebKitPlatformSupport is defined in Platform.h
7 years, 10 months ago (2013-02-21 15:43:26 UTC) #1
pilgrim_google
7 years, 10 months ago (2013-02-21 15:44:11 UTC) #2
jamesr
lgtm (but I don't have powers for content/public/test)
7 years, 10 months ago (2013-02-21 17:16:15 UTC) #3
pilgrim_google
7 years, 10 months ago (2013-02-21 18:24:16 UTC) #4
pilgrim_google
7 years, 10 months ago (2013-02-21 18:37:53 UTC) #5
sky
LGTM
7 years, 10 months ago (2013-02-21 20:10:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/11824036/8001
7 years, 10 months ago (2013-02-21 20:11:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/11824036/8001
7 years, 10 months ago (2013-02-21 22:07:58 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-02-21 23:54:06 UTC) #9
Message was sent while issue was closed.
Change committed as 183905

Powered by Google App Engine
This is Rietveld 408576698