Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4018)

Unified Diff: chrome/browser/ui/webui/sync_setup_handler_unittest.cc

Issue 11824021: [sync] [chromeos] Fix setup flow when sync data is cleared via dashboard and sync is set up again (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Disable unittests that behave differently based on whether client login flow is enabled or not. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/sync_setup_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_setup_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/sync_setup_handler_unittest.cc b/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
index 84d2bfcbc6314debd2fadd0a6072f46151af52c5..f6d6869c219da3668fd6cfe8502fb546030c299d 100644
--- a/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
+++ b/chrome/browser/ui/webui/sync_setup_handler_unittest.cc
@@ -521,7 +521,8 @@ TEST_P(SyncSetupHandlerTest, DisplayForceLogin) {
// Verifies that the handler correctly handles a cancellation when
// it is displaying the spinner to the user.
-TEST_P(SyncSetupHandlerTest, DisplayConfigureWithBackendDisabledAndCancel) {
+TEST_P(SyncSetupHandlerTest,
+ DISABLED_DisplayConfigureWithBackendDisabledAndCancel) {
EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn())
.WillRepeatedly(Return(true));
EXPECT_CALL(*mock_pss_, IsSyncTokenAvailable())
@@ -557,7 +558,7 @@ TEST_P(SyncSetupHandlerTest, DisplayConfigureWithBackendDisabledAndCancel) {
// Verifies that the handler correctly transitions from showing the spinner
// to showing a configuration page when signin completes successfully.
TEST_P(SyncSetupHandlerTest,
- DisplayConfigureWithBackendDisabledAndSigninSuccess) {
+ DISABLED_DisplayConfigureWithBackendDisabledAndSigninSuccess) {
Roger Tawa OOO till Jul 10th 2013/01/09 15:03:23 Instead of always disabling this test, you should
James Hawkins 2013/01/09 18:27:47 Yeah, I can't LG adding a disabled test.
EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn())
.WillRepeatedly(Return(true));
EXPECT_CALL(*mock_pss_, IsSyncTokenAvailable())
« no previous file with comments | « chrome/browser/ui/webui/sync_setup_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698