chrome/browser/ui/webui/sync_setup_handler.cc - Issue 11824021: [sync] [chromeos] Fix setup flow when sync data is cleared via dashboard and sync is set up again

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_setup_handler.cc

Issue 11824021: [sync] [chromeos] Fix setup flow when sync data is cleared via dashboard and sync is set up again (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Disable unittests that behave differently based on whether client login flow is enabled or not. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/sync_setup_handler.cc

diff --git a/chrome/browser/ui/webui/sync_setup_handler.cc b/chrome/browser/ui/webui/sync_setup_handler.cc

index fe275f9895d07f0a983a12b7936bef60ebf59660..657e064007fbb97df7ffbd26ddc4d874215fd826 100644

--- a/chrome/browser/ui/webui/sync_setup_handler.cc

+++ b/chrome/browser/ui/webui/sync_setup_handler.cc

@@ -393,8 +393,12 @@ void SyncSetupHandler::DisplayConfigureSync(bool show_advanced,

service->UnsuppressAndStart();

DisplaySpinner();

// To listen to the token available notifications, start SigninTracker.

- signin_tracker_.reset(new SigninTracker(GetProfile(), this));

+ signin_tracker_.reset(

+ new SigninTracker(GetProfile(),

+ this,

+ SigninTracker::SERVICES_INITIALIZING));

return;

}

« no previous file with comments | « no previous file | chrome/browser/ui/webui/sync_setup_handler_unittest.cc » ('j') | chrome/browser/ui/webui/sync_setup_handler_unittest.cc » ('J')