chrome/browser/extensions/menu_manager.cc - Issue 11824004: Do not pass URLs in onUpdated events to extensions unless they have the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/menu_manager.cc

Issue 11824004: Do not pass URLs in onUpdated events to extensions unless they have the (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Improve ExtensionApiTest.TabsNoPermissions test Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tabs_apitest.cc ('k') | chrome/test/data/extensions/api_test/tabs/no_permissions/manifest.json » ('j') | chrome/test/data/extensions/api_test/tabs/no_permissions/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/menu_manager.cc

diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc

index b20afaf90baf4d916024f1d6d63020a4a9261d78..077c5649cc67d863ee6f005e6dc069316c72a402 100644

--- a/chrome/browser/extensions/menu_manager.cc

+++ b/chrome/browser/extensions/menu_manager.cc

@@ -644,8 +644,7 @@ void MenuManager::ExecuteCommand(Profile* profile,

if (!extension || !extension->is_platform_app()) {

// Note: web_contents are NULL in unit tests :(

if (web_contents) {

- args->Append(ExtensionTabUtil::CreateTabValue(

- web_contents, ExtensionTabUtil::INCLUDE_PRIVACY_SENSITIVE_FIELDS));

+ args->Append(ExtensionTabUtil::CreateTabValue(web_contents));

} else {

args->Append(new DictionaryValue());

}