chrome/browser/extensions/extension_tabs_apitest.cc - Issue 11824004: Do not pass URLs in onUpdated events to extensions unless they have the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 11824004: Do not pass URLs in onUpdated events to extensions unless they have the (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Improve ExtensionApiTest.TabsNoPermissions test Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tab_util_android.cc ('k') | chrome/browser/extensions/menu_manager.cc » ('j') | chrome/test/data/extensions/api_test/tabs/no_permissions/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_tabs_apitest.cc

diff --git a/chrome/browser/extensions/extension_tabs_apitest.cc b/chrome/browser/extensions/extension_tabs_apitest.cc

index 29a8fce439e4f9bf814b6cb070fff4fcc4954adf..93828b35a7597aded77623fdaf51cafc40f687b3 100644

--- a/chrome/browser/extensions/extension_tabs_apitest.cc

+++ b/chrome/browser/extensions/extension_tabs_apitest.cc

@@ -191,6 +191,10 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabsOnUpdated) {

ASSERT_TRUE(RunExtensionTest("tabs/on_updated")) << message_;

}

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabsNoPermissions) {

+ ASSERT_TRUE(RunExtensionTest("tabs/no_permissions")) << message_;

IN_PROC_BROWSER_TEST_F(ExtensionApiTest,

MAYBE_FocusWindowDoesNotExitFullscreen) {

browser()->window()->EnterFullscreen(