runtime/vm/flow_graph_optimizer.cc - Issue 1182323012: Disable TryCreateICData until a crash in object.cc has been investigated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 1182323012: Disable TryCreateICData until a crash in object.cc has been investigated. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc

index cc16479ee5e0473b76f6089f88ce6121ad8b1a88..6e894982823c3ff2532adc216cf371e0de025f25 100644

--- a/runtime/vm/flow_graph_optimizer.cc

+++ b/runtime/vm/flow_graph_optimizer.cc

@@ -163,6 +163,7 @@ static bool IsNumberCid(intptr_t cid) {

// Attempt to build ICData for call using propagated class-ids.

bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) {

+ return false;

ASSERT(call->HasICData());

if (call->ic_data()->NumberOfChecks() > 0) {

// This occurs when an instance call has too many checks, will be converted

« no previous file with comments | « no previous file | no next file » | no next file with comments »