Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: runtime/vm/flow_graph_optimizer.cc

Issue 1182323012: Disable TryCreateICData until a crash in object.cc has been investigated. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_optimizer.h" 5 #include "vm/flow_graph_optimizer.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/cha.h" 8 #include "vm/cha.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 156
157 157
158 // TODO(srdjan): Test/support other number types as well. 158 // TODO(srdjan): Test/support other number types as well.
159 static bool IsNumberCid(intptr_t cid) { 159 static bool IsNumberCid(intptr_t cid) {
160 return (cid == kSmiCid) || (cid == kDoubleCid); 160 return (cid == kSmiCid) || (cid == kDoubleCid);
161 } 161 }
162 162
163 163
164 // Attempt to build ICData for call using propagated class-ids. 164 // Attempt to build ICData for call using propagated class-ids.
165 bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) { 165 bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) {
166 return false;
166 ASSERT(call->HasICData()); 167 ASSERT(call->HasICData());
167 if (call->ic_data()->NumberOfChecks() > 0) { 168 if (call->ic_data()->NumberOfChecks() > 0) {
168 // This occurs when an instance call has too many checks, will be converted 169 // This occurs when an instance call has too many checks, will be converted
169 // to megamorphic call. 170 // to megamorphic call.
170 return false; 171 return false;
171 } 172 }
172 if (FLAG_warn_on_javascript_compatibility) { 173 if (FLAG_warn_on_javascript_compatibility) {
173 // Do not make the instance call megamorphic if the callee needs to decode 174 // Do not make the instance call megamorphic if the callee needs to decode
174 // the calling code sequence to lookup the ic data and verify if a warning 175 // the calling code sequence to lookup the ic data and verify if a warning
175 // has already been issued or not. 176 // has already been issued or not.
(...skipping 8543 matching lines...) Expand 10 before | Expand all | Expand 10 after
8719 8720
8720 // Insert materializations at environment uses. 8721 // Insert materializations at environment uses.
8721 for (intptr_t i = 0; i < exits_collector_.exits().length(); i++) { 8722 for (intptr_t i = 0; i < exits_collector_.exits().length(); i++) {
8722 CreateMaterializationAt( 8723 CreateMaterializationAt(
8723 exits_collector_.exits()[i], alloc, *slots); 8724 exits_collector_.exits()[i], alloc, *slots);
8724 } 8725 }
8725 } 8726 }
8726 8727
8727 8728
8728 } // namespace dart 8729 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698