Zero warnings from the analyzer!

Zero warnings from the analyzer!

Ok, not really zero. Actually 72 if you include warnings from non-sky packages and if you include bogus warnings that can be filtered out.

If you pipe the analyzer's output through the following perl script, though, you get zero warnings on the stock app with this patch:

while (defined($_ = <STDIN>)) {
    s|out/android_Debug/gen/dart-pkg/sky/|sky/sdk/|gos;
    next if m|/dart-pkg/|os; # other packages
    next if m|^\[warning] Missing concrete implementation of 'RenderObject.toString'|os; # https://github.com/dart-lang/sdk/issues/23606
    print;
}

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/a0841841cf01b51f58afa4df3e25a795c11a5063

[abarth-chromium, 2015-06-18 20:58:34]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2015-06-18 20:58:35]

lgtm

[Hixie, 2015-06-18 23:11:33]

Committed patchset #1 (id:1) manually as
a0841841cf01b51f58afa4df3e25a795c11a5063 (presubmit successful).