Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: sky/sdk/lib/widgets/ink_well.dart

Issue 1182323009: Zero warnings from the analyzer! (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/rendering/box.dart ('k') | sky/sdk/lib/widgets/widget.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/widgets/ink_well.dart
diff --git a/sky/sdk/lib/widgets/ink_well.dart b/sky/sdk/lib/widgets/ink_well.dart
index 95a78daeb0094106e2398eda4cba105c682b8b1b..e40c37014684c679678985b08aa11ce3da0ee928 100644
--- a/sky/sdk/lib/widgets/ink_well.dart
+++ b/sky/sdk/lib/widgets/ink_well.dart
@@ -65,14 +65,15 @@ class RenderInkWell extends RenderProxyBox {
final List<InkSplash> _splashes = new List<InkSplash>();
void handleEvent(sky.Event event, BoxHitTestEntry entry) {
- switch (event.type) {
- case 'gesturetapdown':
- // TODO(abarth): We should position the splash at the location of the tap.
- _startSplash(event.primaryPointer, entry.localPosition);
- break;
- case 'gesturetap':
- _confirmSplash(event.primaryPointer);
- break;
+ if (event is sky.GestureEvent) {
+ switch (event.type) {
+ case 'gesturetapdown':
+ _startSplash(event.primaryPointer, entry.localPosition);
+ break;
+ case 'gesturetap':
+ _confirmSplash(event.primaryPointer);
+ break;
+ }
}
}
« no previous file with comments | « sky/sdk/lib/rendering/box.dart ('k') | sky/sdk/lib/widgets/widget.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698