Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/mjsunit/harmony/private.js

Issue 1182303004: All private symbols are own symbols (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/macros.py ('K') | « src/runtime/runtime-symbol.cc ('k') | test/mjsunit/own-symbols.js » ('j') | test/mjsunit/own-symbols.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/harmony/private.js
diff --git a/test/mjsunit/harmony/private.js b/test/mjsunit/harmony/private.js
index c08daf105055cfcc9ac8ea940c4372bf0b8e0803..8c7ec33f9f85a8932608f1eabe85c7cae70e3247 100644
--- a/test/mjsunit/harmony/private.js
+++ b/test/mjsunit/harmony/private.js
@@ -241,7 +241,8 @@ function TestKeyGet(obj) {
var obj2 = Object.create(obj)
for (var i in symbols) {
assertEquals(i|0, obj[symbols[i]])
- assertEquals(i|0, obj2[symbols[i]])
+ // Private symbols key own-properties..
rossberg 2015/06/15 12:09:11 Nit: extra period
wingo 2015/06/16 07:09:45 Done.
+ assertEquals(undefined, obj2[symbols[i]])
}
}
« src/macros.py ('K') | « src/runtime/runtime-symbol.cc ('k') | test/mjsunit/own-symbols.js » ('j') | test/mjsunit/own-symbols.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698