Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: src/macros.py

Issue 1182303004: All private symbols are own symbols (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/lookup.h ('k') | src/objects.h » ('j') | test/mjsunit/harmony/private.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/macros.py
diff --git a/src/macros.py b/src/macros.py
index 94f94c39e18c91321ca086bd1b7da8c32c87da34..d2827a2b1a64c2d1a731e8c401903674c5c6cc02 100644
--- a/src/macros.py
+++ b/src/macros.py
@@ -161,8 +161,8 @@ macro HAS_INDEX(array, index, is_array) = ((is_array && %_HasFastPackedElements(
# Private names.
# GET_PRIVATE should only be used if the property is known to exists on obj
# itself (it should really use %GetOwnProperty, but that would be way slower).
rossberg 2015/06/15 12:09:11 Is this comment still needed? It seems to work tha
wingo 2015/06/16 07:09:45 Removed.
-macro GLOBAL_PRIVATE(name) = (%CreateGlobalPrivateOwnSymbol(name));
-macro NEW_PRIVATE_OWN(name) = (%CreatePrivateOwnSymbol(name));
+macro GLOBAL_PRIVATE(name) = (%CreateGlobalPrivateSymbol(name));
+macro NEW_PRIVATE_OWN(name) = (%CreatePrivateSymbol(name));
rossberg 2015/06/15 12:09:11 Rename this to NEW_PRIVATE
wingo 2015/06/16 07:09:45 Done.
macro IS_PRIVATE(sym) = (%SymbolIsPrivate(sym));
macro HAS_PRIVATE(obj, sym) = (%HasOwnProperty(obj, sym));
macro HAS_DEFINED_PRIVATE(obj, sym) = (!IS_UNDEFINED(obj[sym]));
« no previous file with comments | « src/lookup.h ('k') | src/objects.h » ('j') | test/mjsunit/harmony/private.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698