Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1182233003: IndexedDB: Replace use of DOMError with DOMException (Closed)

Created:
5 years, 6 months ago by jsbell
Modified:
5 years, 3 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, jsbell+idb_chromium.org, dgrogan, cmumford
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IndexedDB: Replace use of DOMError with DOMException DOMError has been removed from the DOM standard in favor of DOMException. We've added instrumentation to measure the use of the constructors and methods (http://crrev.com/1151023004), but given that DOMException is drop-in compatible (same name/message properties) when minted by an API, we can try just switching over. This would only break code that does 'instanceof' tests, and we didn't even have any of those for IndexedDB. Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/XAlBg66UB7c/G4GNCFLnwCQJ R=philipj@opera.com BUG=460725

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -39 lines) Patch
A LayoutTests/storage/indexeddb/error-attributes.html View 1 chunk +34 lines, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBDatabaseCallbacks.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabaseCallbacks.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBFactory.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBOpenDBRequest.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBRequest.h View 1 5 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 1 5 chunks +6 lines, -4 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBRequestTest.cpp View 1 3 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.h View 1 5 chunks +5 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 1 3 chunks +4 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBTransactionTest.cpp View 1 4 chunks +5 lines, -4 lines 0 comments Download
M Source/modules/indexeddb/WebIDBCallbacksImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jsbell
philipj@ - we may want to wait for your user counters to gather data before ...
5 years, 6 months ago (2015-06-12 21:59:49 UTC) #1
philipj_slow
On 2015/06/12 21:59:49, jsbell wrote: > philipj@ - we may want to wait for your ...
5 years, 6 months ago (2015-06-15 10:23:37 UTC) #2
jsbell
On 2015/06/15 10:23:37, philipj wrote: > This is what http://w3c.github.io/IndexedDB/ says Don't put too much ...
5 years, 6 months ago (2015-06-15 15:17:19 UTC) #3
jsbell
On 2015/06/15 15:17:19, jsbell wrote: > I'll ask standards folks for feedback to see if ...
5 years, 6 months ago (2015-06-19 16:59:05 UTC) #4
jsbell
5 years, 3 months ago (2015-09-23 17:35:56 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698