tools/gn/ninja_target_writer.cc - Issue 1182183003: Move EndsWith to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 1182183003: Move EndsWith to base namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_target_writer.cc

diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc

index 78a2c8f6e282c88f4ce0dd6f446be52a3e8d5a27..e03b2d21a25898d6160c69944b68f2cd81fe3a26 100644

--- a/tools/gn/ninja_target_writer.cc

+++ b/tools/gn/ninja_target_writer.cc

@@ -242,7 +242,7 @@ void NinjaTargetWriter::WriteStampForTarget(

// First validate that the target's dependency is a stamp file. Otherwise,

// we shouldn't have gotten here!

- CHECK(EndsWith(stamp_file.value(), ".stamp", false))

+ CHECK(base::EndsWith(stamp_file.value(), ".stamp", false))

<< "Output should end in \".stamp\" for stamp file output. Instead got: "

<< "\"" << stamp_file.value() << "\"";

« no previous file with comments | « tools/gn/ninja_binary_target_writer.cc ('k') | ui/base/l10n/l10n_util.cc » ('j') | no next file with comments »