Return false in AwWebContentsDelegate::CanDownload

android_webview/native/aw_web_contents_delegate.cc

Index: android_webview/native/aw_web_contents_delegate.cc
diff --git a/android_webview/native/aw_web_contents_delegate.cc b/android_webview/native/aw_web_contents_delegate.cc
index fb9283e30d5568f122ec4f1e7ff115152ffa505e..bfd4741698148bf4309a82ab0702d039e77b8dec 100644
--- a/android_webview/native/aw_web_contents_delegate.cc
+++ b/android_webview/native/aw_web_contents_delegate.cc
@@ -10,10 +10,8 @@
 #include "base/android/scoped_java_ref.h"
 #include "base/lazy_instance.h"
 #include "base/message_loop.h"
-#include "content/public/browser/android/download_controller_android.h"
 #include "content/public/browser/web_contents.h"
 #include "jni/AwWebContentsDelegate_jni.h"
-#include "net/http/http_request_headers.h"
 
 using base::android::AttachCurrentThread;
 using base::android::ScopedJavaLocalRef;
@@ -57,10 +55,6 @@ void AwWebContentsDelegate::FindReply(WebContents* web_contents,
 bool AwWebContentsDelegate::CanDownload(content::RenderViewHost* source,
                                         int request_id,
                                         const std::string& request_method) {
-  if (request_method == net::HttpRequestHeaders::kGetMethod) {
-    content::DownloadControllerAndroid::Get()->CreateGETDownload(
-        source, request_id);
-  }
   return false;

[boliu, 2013/01/09 00:47:46]

could you put a NOTREACHED here?

[joth, 2013/01/09 00:53:18]

+1

also lets add a comment to explain why:
// Android webview intercepts download in its resource dispatcher host delegate,
so should not reach here. (Note this method is actually an internal detail of
chrome/ layer and doesn't really belong on the WebContentsDelegate interface)

[nilesh, 2013/01/09 01:01:39]

Added NOTREACHED and explanation.
I have skipped the "Note" as it does not feel appropriate here in the
implementation. Let me know if you feel strongly about it.

 }