Return false in AwWebContentsDelegate::CanDownload

android_webview/native/aw_web_contents_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/native/aw_web_contents_delegate.h"
 
 #include "android_webview/browser/find_helper.h"
 #include "android_webview/native/aw_contents.h"
 #include "android_webview/native/aw_javascript_dialog_creator.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/lazy_instance.h"
 #include "base/message_loop.h"
-#include "content/public/browser/android/download_controller_android.h"
 #include "content/public/browser/web_contents.h"
 #include "jni/AwWebContentsDelegate_jni.h"
-#include "net/http/http_request_headers.h"
 
 using base::android::AttachCurrentThread;
 using base::android::ScopedJavaLocalRef;
 using content::WebContents;
 
 namespace android_webview {
 
 static base::LazyInstance<AwJavaScriptDialogCreator>::Leaky
     g_javascript_dialog_creator = LAZY_INSTANCE_INITIALIZER;
 
@@ skipping 23 matching lines @@
 
   aw_contents->GetFindHelper()->HandleFindReply(request_id,
                                                 number_of_matches,
                                                 active_match_ordinal,
                                                 final_update);
 }
 
 bool AwWebContentsDelegate::CanDownload(content::RenderViewHost* source,
                                         int request_id,
                                         const std::string& request_method) {
-  if (request_method == net::HttpRequestHeaders::kGetMethod) {
-    content::DownloadControllerAndroid::Get()->CreateGETDownload(
-        source, request_id);
-  }
   return false;

[boliu, 2013/01/09 00:47:46]

could you put a NOTREACHED here?

[joth, 2013/01/09 00:53:18]

+1

also lets add a comment to explain why:
// Android webview intercepts download in its resource dispatcher host delegate,
so should not reach here. (Note this method is actually an internal detail of
chrome/ layer and doesn't really belong on the WebContentsDelegate interface)

[nilesh, 2013/01/09 01:01:39]

Added NOTREACHED and explanation.
I have skipped the "Note" as it does not feel appropriate here in the
implementation. Let me know if you feel strongly about it.

 }
 
 void AwWebContentsDelegate::OnStartDownload(WebContents* source,
                                             content::DownloadItem* download) {
   NOTREACHED();  // We always return false in CanDownload.
 }
 
 void AwWebContentsDelegate::AddNewContents(content::WebContents* source,
                                            content::WebContents* new_contents,
                                            WindowOpenDisposition disposition,
@@ skipping 51 matching lines @@
   if (java_delegate.obj()) {
     Java_AwWebContentsDelegate_activateContents(env, java_delegate.obj());
   }
 }
 
 bool RegisterAwWebContentsDelegate(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android_webview