chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java - Issue 1182083005: Re-engineer edit screen in enhanced bookmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java

Issue 1182083005: Re-engineer edit screen in enhanced bookmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to comments. Lots of comments... Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java_staging/res/layout/eb_edit.xml ('K') | « chrome/android/java_staging/res/menu/eb_action_bar_menu.xml ('k') | chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java » ('j') | chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkEditActivity.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java

index d0f138acee37964767321bf3840da2659d68f0a9..03897eb63b350a86091443d28ae6f11a61211fd6 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/CompositorChromeActivity.java

@@ -406,7 +406,7 @@ public abstract class CompositorChromeActivity extends ChromeActivity

EnhancedBookmarkUtils.addBookmarkAndShowSnackbar(bookmarkModel,

tabToBookmark, getSnackbarManager(), CompositorChromeActivity.this);

} else {

- EnhancedBookmarkUtils.startDetailActivity(CompositorChromeActivity.this,

+ EnhancedBookmarkUtils.startEditActivity(CompositorChromeActivity.this,

new BookmarkId(bookmarkId, BookmarkType.NORMAL));

}

bookmarkModel.removeModelObserver(this);