Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3426)

Unified Diff: chrome/android/java_staging/res/layout/eb_edit.xml

Issue 1182083005: Re-engineer edit screen in enhanced bookmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to comments. Lots of comments... Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java_staging/res/layout/eb_edit.xml
diff --git a/chrome/android/java_staging/res/layout/eb_edit.xml b/chrome/android/java_staging/res/layout/eb_edit.xml
new file mode 100644
index 0000000000000000000000000000000000000000..88a57346734c9594541a8a697d2222cbe565fa1b
--- /dev/null
+++ b/chrome/android/java_staging/res/layout/eb_edit.xml
@@ -0,0 +1,82 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+ Copyright 2015 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file.
+-->
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:orientation="vertical" >
+
+ <android.support.v7.widget.Toolbar
+ android:id="@+id/toolbar"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:background="?attr/colorPrimary"
+ android:minHeight="?attr/actionBarSize" />
Kibeom Kim (inactive) 2015/06/18 00:25:37 Btw, do you know if we're doing shadow for toolbar
Ian Wen 2015/06/18 01:19:34 Hmm I can add a shadow here. (personally it looks
+
+ <ScrollView
+ android:layout_width="match_parent"
+ android:layout_height="match_parent" >
+
+ <LinearLayout
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_marginEnd="16dp"
+ android:layout_marginStart="16dp"
+ android:layout_marginTop="8dp"
+ android:layout_marginBottom="8dp"
+ android:orientation="vertical" >
+
+ <org.chromium.chrome.browser.widget.FloatLabelLayout
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content" >
+
+ <EditText
+ android:id="@+id/title_text"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:hint="@string/bookmark_name"
+ android:imeOptions="flagNoExtractUi"
+ android:inputType="textCapSentences|textAutoCorrect"
+ android:singleLine="true" />
+ </org.chromium.chrome.browser.widget.FloatLabelLayout>
+
+ <TextView
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:paddingEnd="3dp"
+ android:paddingStart="3dp"
+ android:paddingTop="8dp"
+ android:text="@string/bookmark_folder"
+ android:textAppearance="@style/TextAppearance.AppCompat.Small" />
+
+ <TextView
+ android:id="@+id/folder_text"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:paddingBottom="8dp"
+ android:paddingEnd="3dp"
+ android:paddingStart="3dp"
+ android:paddingTop="8dp"
+ android:textAppearance="@style/TextAppearance.AppCompat.Medium"
+ android:textColor="@color/dark_mode_tint" />
+
+ <org.chromium.chrome.browser.widget.FloatLabelLayout
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content" >
+
+ <EditText
+ android:id="@+id/url_text"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:hint="@string/bookmark_url"
+ android:imeOptions="flagNoExtractUi"
+ android:inputType="textUri"
+ android:singleLine="true" />
+ </org.chromium.chrome.browser.widget.FloatLabelLayout>
+ </LinearLayout>
+ </ScrollView>
+
+</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698