Implement `.instanceMembers`.

Implement `.instanceMembers`.

Also implement support for invoke of operators.

The `owner` of an instance-member is not set.

The members are replicated in the declarations. We should perhaps make them
top-level fields, so they can be refenrenced from everywhere.

Applies on top of https://codereview.chromium.org/1181993003
BUG=
R=eernst@google.com

Committed: https://github.com/dart-lang/reflectable/commit/858d67f84eea70a6c16a16abd73974972951a4df

[sigurdm, 2015-06-12 14:12:08]

Patchset #1 (id:1) has been deleted

[sigurdm, 2015-06-12 14:13:16]

Patchset #1 (id:20001) has been deleted

[sigurdm, 2015-06-12 14:14:44]

sigurdm@google.com changed reviewers:
+ eernst@google.com

[eernst, 2015-06-18 12:21:13]

LGTM.

This CL seems to contain a number of diffs which are already present in a CL
that I reviewed earlier; did not comment on those parts again.

One issue may call for a decision on how to proceed: Caching. We may end up
concluding that it is a non-problem, but even that might be good to document
somewhere.

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/mirror...
File reflectable/lib/mirrors.dart (right):

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/mirror...
reflectable/lib/mirrors.dart:296: // The non-abstract members declared in this
class.
May need adjustment to match treatment of abstract members.

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/mirror...
reflectable/lib/mirrors.dart:299: Map<String, MethodMirror> get staticMembers;
In the static case we don't even have the "what to do about abstract" problem.
;)

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/src/mi...
File reflectable/lib/src/mirrors_unimpl.dart (right):

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/src/mi...
reflectable/lib/src/mirrors_unimpl.dart:149: // We do not support reflection on
abstract methods.
Same as earlier patch (presumably this CL is built upon that one). Will omit
comments on this topic in this CL.

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/src/tr...
File reflectable/lib/src/transformer_implementation.dart (right):

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/src/tr...
reflectable/lib/src/transformer_implementation.dart:72: new Map<ClassElement,
Map<String, ExecutableElement>>();
Do we need an more global mechanism to guide the extent to which caching is
used? Presumably we only cache results about statically detectable entities
(that is, source code related entities like classes and methods, and const
instances like metadata). Maybe we can simply rely on large caches to be aligned
with large applications, concluding that it is never an issue?

[sigurdm, 2015-06-18 14:22:27]

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/mirror...
File reflectable/lib/mirrors.dart (right):

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/mirror...
reflectable/lib/mirrors.dart:296: // The non-abstract members declared in this
class.
On 2015/06/18 12:21:12, eernst wrote:
> May need adjustment to match treatment of abstract members.

Acknowledged.

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/mirror...
reflectable/lib/mirrors.dart:299: Map<String, MethodMirror> get staticMembers;
On 2015/06/18 12:21:12, eernst wrote:
> In the static case we don't even have the "what to do about abstract" problem.
> ;)

Acknowledged.

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/src/mi...
File reflectable/lib/src/mirrors_unimpl.dart (right):

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/src/mi...
reflectable/lib/src/mirrors_unimpl.dart:149: // We do not support reflection on
abstract methods.
On 2015/06/18 12:21:12, eernst wrote:
> Same as earlier patch (presumably this CL is built upon that one). Will omit
> comments on this topic in this CL.

Yes - I have messed up the upload

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/src/tr...
File reflectable/lib/src/transformer_implementation.dart (right):

https://codereview.chromium.org/1182083002/diff/100001/reflectable/lib/src/tr...
reflectable/lib/src/transformer_implementation.dart:72: new Map<ClassElement,
Map<String, ExecutableElement>>();
On 2015/06/18 12:21:12, eernst wrote:
> Do we need an more global mechanism to guide the extent to which caching is
> used? Presumably we only cache results about statically detectable entities
> (that is, source code related entities like classes and methods, and const
> instances like metadata). Maybe we can simply rely on large caches to be
aligned
> with large applications, concluding that it is never an issue?

I am not sure - will leave a todo.

[sigurdm, 2015-06-18 14:22:40]

Committed patchset #5 (id:120001) manually as
858d67f84eea70a6c16a16abd73974972951a4df (presubmit successful).