Add support for getters, setters and constructors in declarations of classMirrors.

Add support for getters, setters and constructors in declarations of classMirrors.

BUG=
R=eernst@google.com

Committed: https://github.com/dart-lang/reflectable/commit/d4aef84ebb7b84ed627e1339ca74e6a51173916e

[sigurdm, 2015-06-12 08:54:20]

sigurdm@google.com changed reviewers:
+ eernst@google.com

[eernst, 2015-06-18 10:07:19]

Some comments about keeping abstract members in view after all, otherwise LGTM.

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/mirrors...
File reflectable/lib/src/mirrors_unimpl.dart (right):

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/mirrors...
reflectable/lib/src/mirrors_unimpl.dart:149: // We do not support reflection on
abstract methods.
Let's include abstract methods even though dart:mirrors doesn't. Then we'll keep
track of the cases that don't work in pre-transform form by putting them in
.status (as opposed to spending time on fixing them in any way), and as an bonus
document various little glitches in dart:mirrors that may or may not be known.

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/mirrors...
reflectable/lib/src/mirrors_unimpl.dart:179: // We do not support reflection on
abstract methods.
We may then support them after all.

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/mirrors...
reflectable/lib/src/mirrors_unimpl.dart:181: bool get isAbstract => false;
In case we support abstract methods, reverting this line should be sufficient.

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/reflect...
File reflectable/lib/src/reflectable_implementation.dart (right):

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/reflect...
reflectable/lib/src/reflectable_implementation.dart:497: // members in
declarations. We choose to go the same route.
In case we include abstract members, I guess it's enough to delete this whole
`if`.

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/transfo...
File reflectable/lib/src/transformer_implementation.dart (right):

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/transfo...
reflectable/lib/src/transformer_implementation.dart:112:
assert(!element.isAbstract);
Seems to be enough to revert this one.

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/transfo...
reflectable/lib/src/transformer_implementation.dart:420: if
(accessor.isAbstract) return false;
With abstract members included, should this line be deleted?

[sigurdm, 2015-06-18 11:04:03]

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/mirrors...
File reflectable/lib/src/mirrors_unimpl.dart (right):

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/mirrors...
reflectable/lib/src/mirrors_unimpl.dart:149: // We do not support reflection on
abstract methods.
On 2015/06/18 10:07:18, eernst wrote:
> Let's include abstract methods even though dart:mirrors doesn't. Then we'll
keep
> track of the cases that don't work in pre-transform form by putting them in
> .status (as opposed to spending time on fixing them in any way), and as an
bonus
> document various little glitches in dart:mirrors that may or may not be known.

Done.

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/mirrors...
reflectable/lib/src/mirrors_unimpl.dart:179: // We do not support reflection on
abstract methods.
On 2015/06/18 10:07:18, eernst wrote:
> We may then support them after all.

Done.

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/mirrors...
reflectable/lib/src/mirrors_unimpl.dart:181: bool get isAbstract => false;
On 2015/06/18 10:07:18, eernst wrote:
> In case we support abstract methods, reverting this line should be sufficient.

Done.

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/reflect...
File reflectable/lib/src/reflectable_implementation.dart (right):

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/reflect...
reflectable/lib/src/reflectable_implementation.dart:497: // members in
declarations. We choose to go the same route.
On 2015/06/18 10:07:18, eernst wrote:
> In case we include abstract members, I guess it's enough to delete this whole
> `if`.

Done.

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/transfo...
File reflectable/lib/src/transformer_implementation.dart (right):

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/transfo...
reflectable/lib/src/transformer_implementation.dart:112:
assert(!element.isAbstract);
On 2015/06/18 10:07:18, eernst wrote:
> Seems to be enough to revert this one.

Done.

https://codereview.chromium.org/1181993003/diff/1/reflectable/lib/src/transfo...
reflectable/lib/src/transformer_implementation.dart:420: if
(accessor.isAbstract) return false;
On 2015/06/18 10:07:19, eernst wrote:
> With abstract members included, should this line be deleted?

Done.

[sigurdm, 2015-06-18 11:11:00]

Committed patchset #3 (id:40001) manually as
d4aef84ebb7b84ed627e1339ca74e6a51173916e (presubmit successful).