Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182053003: Use plain int for borders widths when possible (Closed)

Created:
5 years, 6 months ago by davve
Modified:
5 years, 6 months ago
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, blink-reviews-style_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use plain int for borders widths when possible Chromium coding style (not overridden by Blink's in this case) states: Do not use unsigned types to mean "this value should never be < 0". The BorderValue width storage is currently 26 bits wide so it's easily contained in a plain int. No functional change expected. BUG=496033 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M Source/core/layout/LayoutTable.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTableSection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/style/BorderData.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/style/BorderValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/ComputedStyle.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
davve
PTAL. Unsigned ints always makes me a bit nervous. There are some more I plan ...
5 years, 6 months ago (2015-06-15 08:18:56 UTC) #2
mstensho (USE GERRIT)
lgtm
5 years, 6 months ago (2015-06-15 11:07:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182053003/1
5 years, 6 months ago (2015-06-15 12:42:07 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 13:47:04 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197111

Powered by Google App Engine
This is Rietveld 408576698