Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: Source/core/style/BorderData.h

Issue 1182053003: Use plain int for borders widths when possible (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/layout/LayoutTableSection.cpp ('k') | Source/core/style/BorderValue.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 return true; 59 return true;
60 if (!m_topRight.width().isZero()) 60 if (!m_topRight.width().isZero())
61 return true; 61 return true;
62 if (!m_bottomLeft.width().isZero()) 62 if (!m_bottomLeft.width().isZero())
63 return true; 63 return true;
64 if (!m_bottomRight.width().isZero()) 64 if (!m_bottomRight.width().isZero())
65 return true; 65 return true;
66 return false; 66 return false;
67 } 67 }
68 68
69 unsigned borderLeftWidth() const 69 int borderLeftWidth() const
70 { 70 {
71 if (!m_image.hasImage() && (m_left.style() == BNONE || m_left.style() == BHIDDEN)) 71 if (!m_image.hasImage() && (m_left.style() == BNONE || m_left.style() == BHIDDEN))
72 return 0; 72 return 0;
73 return m_left.width(); 73 return m_left.width();
74 } 74 }
75 75
76 unsigned borderRightWidth() const 76 int borderRightWidth() const
77 { 77 {
78 if (!m_image.hasImage() && (m_right.style() == BNONE || m_right.style() == BHIDDEN)) 78 if (!m_image.hasImage() && (m_right.style() == BNONE || m_right.style() == BHIDDEN))
79 return 0; 79 return 0;
80 return m_right.width(); 80 return m_right.width();
81 } 81 }
82 82
83 unsigned borderTopWidth() const 83 int borderTopWidth() const
84 { 84 {
85 if (!m_image.hasImage() && (m_top.style() == BNONE || m_top.style() == B HIDDEN)) 85 if (!m_image.hasImage() && (m_top.style() == BNONE || m_top.style() == B HIDDEN))
86 return 0; 86 return 0;
87 return m_top.width(); 87 return m_top.width();
88 } 88 }
89 89
90 unsigned borderBottomWidth() const 90 int borderBottomWidth() const
91 { 91 {
92 if (!m_image.hasImage() && (m_bottom.style() == BNONE || m_bottom.style( ) == BHIDDEN)) 92 if (!m_image.hasImage() && (m_bottom.style() == BNONE || m_bottom.style( ) == BHIDDEN))
93 return 0; 93 return 0;
94 return m_bottom.width(); 94 return m_bottom.width();
95 } 95 }
96 96
97 bool operator==(const BorderData& o) const 97 bool operator==(const BorderData& o) const
98 { 98 {
99 return m_left == o.m_left && m_right == o.m_right && m_top == o.m_top && m_bottom == o.m_bottom && m_image == o.m_image 99 return m_left == o.m_left && m_right == o.m_right && m_top == o.m_top && m_bottom == o.m_bottom && m_image == o.m_image
100 && m_topLeft == o.m_topLeft && m_topRight == o.m_topRight && m_bo ttomLeft == o.m_bottomLeft && m_bottomRight == o.m_bottomRight; 100 && m_topLeft == o.m_topLeft && m_topRight == o.m_topRight && m_bo ttomLeft == o.m_bottomLeft && m_bottomRight == o.m_bottomRight;
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 140
141 LengthSize m_topLeft; 141 LengthSize m_topLeft;
142 LengthSize m_topRight; 142 LengthSize m_topRight;
143 LengthSize m_bottomLeft; 143 LengthSize m_bottomLeft;
144 LengthSize m_bottomRight; 144 LengthSize m_bottomRight;
145 }; 145 };
146 146
147 } // namespace blink 147 } // namespace blink
148 148
149 #endif // BorderData_h 149 #endif // BorderData_h
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutTableSection.cpp ('k') | Source/core/style/BorderValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698