Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 11820058: Revert 176134 (Closed)

Created:
7 years, 11 months ago by newt (away)
Modified:
7 years, 11 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert 176134 > [Android] Generate localized strings.xml files at build time. > > This generates localized strings.xml files (e.g. > values-fr/strings.xml) from grd and xtb files at build time. This > means we no longer need to check in localized strings.xml files. Note: > the xtb files are empty until translations are available. > > Benefits: > - 41 fewer extraneous results when grepping Java string IDs > - Switching from maintaining strings in strings.xml over to using a > grd file is One Trivial CL* away: just include English in the list > of languages for which we generate strings.xml files. > > *Restrictions may apply > > BUG=167248 > > Review URL: https://codereview.chromium.org/11659006 TBR=newt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -78 lines) Patch
M build/grit_action.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/java.gypi View 4 chunks +3 lines, -33 lines 0 comments Download
M build/java_apk.gypi View 5 chunks +10 lines, -41 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ui.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
newt (away)
7 years, 11 months ago (2013-01-10 21:05:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698