[Android] Generate localized strings.xml files at build time.

[Android] Generate localized strings.xml files at build time.

This generates localized strings.xml files (e.g.
values-fr/strings.xml) from grd and xtb files at build time. This
means we no longer need to check in localized strings.xml files. Note:
the xtb files are empty until translations are available.

Benefits:
 - 41 fewer extraneous results when grepping Java string IDs
 - Switching from maintaining strings in strings.xml over to using a
   grd file is One Trivial CL* away: just include English in the list
   of languages for which we generate strings.xml files.

*Restrictions may apply

BUG=167248
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176134

[newt (away), 2012-12-21 08:06:13]

What say you?

p.s. This CL only touches chrome/, but I'll add other folders once everyone's
happy with the way things are done.

[newt (away), 2012-12-21 08:12:41]

https://codereview.chromium.org/11659006/diff/1/build/grit_action.gypi
File build/grit_action.gypi (right):

https://codereview.chromium.org/11659006/diff/1/build/grit_action.gypi#newcode31
build/grit_action.gypi:31: '-f', '<(grit_resource_ids)',
this is needed to enable passing the empty string as grit_resource_ids

https://codereview.chromium.org/11659006/diff/1/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/11659006/diff/1/build/java.gypi#newcode104
build/java.gypi:104: '<!@pymod_do_main(grit_info <@(grit_defines) --outputs
"<(out_res_dir)" <(grit_grd_file))',
It would be nice if this duplication could be eliminated: the input here is
simply the output from grit_action.gypi below.  But it doesn't seem that gyp
syntax allows sharing/exporting variables from within an action.

https://codereview.chromium.org/11659006/diff/1/chrome/chrome.gyp
File chrome/chrome.gyp (right):

https://codereview.chromium.org/11659006/diff/1/chrome/chrome.gyp#newcode1084
chrome/chrome.gyp:1084: 'grit_grd_file':
'android/java/grd/android_chrome_strings.grd',
we could make some assumptions here, e.g. that grit_grd_file lives at
<(java_in_dir)/grd/name.grd.  Then we'd just need to pass in "name.grd" instead
of the full path.

[newt (away), 2013-01-03 01:15:37]

+thakis for chrome/
+yfriedman for chrome/android

PTAL. Thanks!

[cjhopman, 2013-01-03 01:38:03]

https://codereview.chromium.org/11659006/diff/5001/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/11659006/diff/5001/build/java.gypi#newcode133
build/java.gypi:133: 'action_name': 'generate_localized_strings_xml',
If this happens before the 'process_resources' action above, can it be moved 
before it in this file? Then the actions appear in the same order that they
actually run.

[Nico, 2013-01-03 01:45:37]

Once this looks good to other reviews, this lgtm from an owners perspective.

[newt (away), 2013-01-03 02:23:02]

https://codereview.chromium.org/11659006/diff/5001/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/11659006/diff/5001/build/java.gypi#newcode133
build/java.gypi:133: 'action_name': 'generate_localized_strings_xml',
On 2013/01/03 01:38:03, cjhopman wrote:
> If this happens before the 'process_resources' action above, can it be moved 
> before it in this file? Then the actions appear in the same order that they
> actually run.

Done.

[newt (away), 2013-01-04 00:17:27]

I added support for generating strings.xml in apks, too.

PTAL, thanks!

https://codereview.chromium.org/11659006/diff/15001/build/java_apk.gypi
File build/java_apk.gypi (right):

https://codereview.chromium.org/11659006/diff/15001/build/java_apk.gypi#newco...
build/java_apk.gypi:127: ['java_strings_grd != ""', {
This is largely copied from java.gypi, which is not ideal.  I considered
creating a new file, java_strings.gypi, but there's not actually much that could
be pulled out into java_strings.gypi.

[shashi, 2013-01-04 00:40:45]

Thanks Newton.
lgtm, mostly nits.

https://codereview.chromium.org/11659006/diff/15001/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/11659006/diff/15001/build/java.gypi#newcode82
build/java.gypi:82: 'grit_grd_file': '<(java_in_dir)/grd/<(java_strings_grd)',
Can this be moved to variables block used by grit_action?

https://codereview.chromium.org/11659006/diff/15001/build/java_apk.gypi
File build/java_apk.gypi (right):

https://codereview.chromium.org/11659006/diff/15001/build/java_apk.gypi#newco...
build/java_apk.gypi:84: 'grit_grd_file%': '',
Is grit_grd_file going to be overridden? Do we need it in this block?

[newt (away), 2013-01-04 01:00:58]

https://codereview.chromium.org/11659006/diff/15001/build/java.gypi
File build/java.gypi (right):

https://codereview.chromium.org/11659006/diff/15001/build/java.gypi#newcode82
build/java.gypi:82: 'grit_grd_file': '<(java_in_dir)/grd/<(java_strings_grd)',
On 2013/01/04 00:40:45, shashi wrote:
> Can this be moved to variables block used by grit_action?

no :(  since grit_grd_file is also used below in the process_resources action

https://codereview.chromium.org/11659006/diff/15001/build/java_apk.gypi
File build/java_apk.gypi (right):

https://codereview.chromium.org/11659006/diff/15001/build/java_apk.gypi#newco...
build/java_apk.gypi:84: 'grit_grd_file%': '',
On 2013/01/04 00:40:45, shashi wrote:
> Is grit_grd_file going to be overridden? Do we need it in this block?

I added this default value for grit_grd_file because without it gyp gives an
undefined variable error (from the usage of grit_grd_file at line 172)

[cjhopman, 2013-01-08 00:11:24]

lgtm

[commit-bot: I haz the power, 2013-01-08 00:14:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/11659006/21001

[newt (away), 2013-01-09 00:56:31]

since https://codereview.chromium.org/11829009/ adds all the xtb files, they can
be removed from this CL.

I also enabled generating localized strings.xml files for the content and ui
folders.

[newt (away), 2013-01-09 00:59:52]

+jam for content.gyp

[jam, 2013-01-09 16:43:30]

On 2013/01/09 00:59:52, newt wrote:
> +jam for content.gyp

lgtm

[commit-bot: I haz the power, 2013-01-10 17:18:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/11659006/35002

[commit-bot: I haz the power, 2013-01-10 19:42:45]

Retried try job too often on linux_chromeos for step(s) browser_tests