Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 11820043: Stop disabling building of partly_invalid.nexe in a corner case (Closed)

Created:
7 years, 11 months ago by Mark Seaborn
Modified:
7 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Stop disabling building of partly_invalid.nexe in a corner case The odd linking problem that only occurred on one trybot (and which I couldn't reproduce locally) in the IRT+glibc case has gone away -- perhaps following toolchain updates -- so re-enable this case. This is in preparation for making all of chrome_browser_tests build in nacl_irt_test_env rather than nacl_env, for uniformity. One of these tests uses partly_invalid.nexe. Without this change, the change https://codereview.chromium.org/11613012/ fails with: scons-out/nacl_irt_test-x86-64-glibc/staging/partly_invalid.nmf.libs failed: Source `scons-out/nacl_irt_test-x86-64-glibc/staging/partly_invalid.nexe' not found, needed by target `scons-out/nacl_irt_test-x86-64-glibc/staging/partly_invalid.nmf.libs'. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3253 TEST=trybots Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M tests/stubout_mode/nacl.scons View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
7 years, 11 months ago (2013-01-10 14:57:36 UTC) #1
Nick Bray (chromium)
LGTM Could this be related to the empty .o files issues reported on nacl-eng?
7 years, 11 months ago (2013-01-10 18:30:52 UTC) #2
Mark Seaborn
7 years, 11 months ago (2013-01-10 19:11:06 UTC) #3
On 2013/01/10 18:30:52, Nick Bray (chromium) wrote:
> Could this be related to the empty .o files issues reported on nacl-eng?

I don't think so.

Powered by Google App Engine
This is Rietveld 408576698