Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: tests/stubout_mode/nacl.scons

Issue 11820043: Stop disabling building of partly_invalid.nexe in a corner case (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/stubout_mode/nacl.scons
diff --git a/tests/stubout_mode/nacl.scons b/tests/stubout_mode/nacl.scons
index 33d3df136dace3f378aa5ed3d563483084ba74fc..dc94213b40c933bdb7415bcbc352b8b04a71cfaa 100644
--- a/tests/stubout_mode/nacl.scons
+++ b/tests/stubout_mode/nacl.scons
@@ -24,17 +24,6 @@ if env.Bit('bitcode') and env.Bit('nacl_pic'):
if env.Bit('build_arm'):
Return()
-# Curiously, on the nacl-win64_glibc_opt trybot, small_tests_irt is
-# producing a version of partly_invalid.nexe that contains an empty
-# ".iplt" section, and ncval_stubout currently fails on empty sections
-# (see http://code.google.com/p/nativeclient/issues/detail?id=2795).
-# I cannot reproduce this locally. It might be a result of
-# non-determinism in the order in which Scons targets are built.
-# TODO(mseaborn): Fix ncval_stubout and investigate why we get an
-# empty ".iplt" section.
-if env.Bit('tests_use_irt') and env.Bit('nacl_glibc'):
- Return()
-
# R-DFA does not support stubout mode
if env.Bit('validator_ragel'):
Return()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698