content/shell/webkit_test_controller.cc - Issue 11820009: Distinguish plugin disconnections from plugin crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/webkit_test_controller.cc

Issue 11820009: Distinguish plugin disconnections from plugin crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add more comments about the possibility that the ID has been reused. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/webkit_test_controller.cc

diff --git a/content/shell/webkit_test_controller.cc b/content/shell/webkit_test_controller.cc

index 7b282765d8500fae63f59b2aee2f807b86fcc367..0041825c32058b925533b5bb8dd195f89d88b91f 100644

--- a/content/shell/webkit_test_controller.cc

+++ b/content/shell/webkit_test_controller.cc

@@ -257,7 +257,8 @@ bool WebKitTestController::OnMessageReceived(const IPC::Message& message) {

return handled;

}

-void WebKitTestController::PluginCrashed(const FilePath& plugin_path) {

+void WebKitTestController::PluginCrashed(const FilePath& plugin_path,

+ base::ProcessId plugin_pid) {

DCHECK(CalledOnValidThread());

printer_->AddErrorMessage("#CRASHED - plugin");

jochen (gone - plz use gerrit) 2013/01/09 08:29:12 can you change the message to "#CRASHED - plugin (

yzshen1 2013/01/09 18:48:11 Done.

}

« no previous file with comments | « content/shell/webkit_test_controller.h ('k') | webkit/plugins/ppapi/plugin_delegate.h » ('j') | no next file with comments »