content/shell/webkit_test_controller.h - Issue 11820009: Distinguish plugin disconnections from plugin crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/webkit_test_controller.h

Issue 11820009: Distinguish plugin disconnections from plugin crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add more comments about the possibility that the ID has been reused. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/webkit_test_controller.h

diff --git a/content/shell/webkit_test_controller.h b/content/shell/webkit_test_controller.h

index 17f01fc3472de64cc6161d17d4e07b34c4d66088..2017a5af47acd589a47d61cac4e7da821a418029 100644

--- a/content/shell/webkit_test_controller.h

+++ b/content/shell/webkit_test_controller.h

@@ -96,7 +96,8 @@ class WebKitTestController : public base::NonThreadSafe,

// WebContentsObserver implementation.

virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

- virtual void PluginCrashed(const FilePath& plugin_path) OVERRIDE;

+ virtual void PluginCrashed(const FilePath& plugin_path,

+ base::ProcessId plugin_pid) OVERRIDE;

virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE;

virtual void RenderViewGone(base::TerminationStatus status) OVERRIDE;

virtual void WebContentsDestroyed(WebContents* web_contents) OVERRIDE;