content/browser/web_contents/web_contents_impl.cc - Issue 11820009: Distinguish plugin disconnections from plugin crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 11820009: Distinguish plugin disconnections from plugin crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add more comments about the possibility that the ID has been reused. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index a5103a512bdf7c4b0cb747e8812302528f1b113e..eeae5e57e59faa01074ca5a49d9800c3d72dfa15 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -2269,9 +2269,10 @@ void WebContentsImpl::OnFindMatchRectsReply(

}

#endif

-void WebContentsImpl::OnCrashedPlugin(const FilePath& plugin_path) {

+void WebContentsImpl::OnCrashedPlugin(const FilePath& plugin_path,

+ base::ProcessId plugin_pid) {

FOR_EACH_OBSERVER(WebContentsObserver, observers_,

- PluginCrashed(plugin_path));

+ PluginCrashed(plugin_path, plugin_pid));

}

void WebContentsImpl::OnAppCacheAccessed(const GURL& manifest_url,