Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 11820009: Distinguish plugin disconnections from plugin crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add more comments about the possibility that the ID has been reused. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 2251 matching lines...) Expand 10 before | Expand all | Expand 10 after
2262 #if defined(OS_ANDROID) 2262 #if defined(OS_ANDROID)
2263 void WebContentsImpl::OnFindMatchRectsReply( 2263 void WebContentsImpl::OnFindMatchRectsReply(
2264 int version, 2264 int version,
2265 const std::vector<gfx::RectF>& rects, 2265 const std::vector<gfx::RectF>& rects,
2266 const gfx::RectF& active_rect) { 2266 const gfx::RectF& active_rect) {
2267 if (delegate_) 2267 if (delegate_)
2268 delegate_->FindMatchRectsReply(this, version, rects, active_rect); 2268 delegate_->FindMatchRectsReply(this, version, rects, active_rect);
2269 } 2269 }
2270 #endif 2270 #endif
2271 2271
2272 void WebContentsImpl::OnCrashedPlugin(const FilePath& plugin_path) { 2272 void WebContentsImpl::OnCrashedPlugin(const FilePath& plugin_path,
2273 base::ProcessId plugin_pid) {
2273 FOR_EACH_OBSERVER(WebContentsObserver, observers_, 2274 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2274 PluginCrashed(plugin_path)); 2275 PluginCrashed(plugin_path, plugin_pid));
2275 } 2276 }
2276 2277
2277 void WebContentsImpl::OnAppCacheAccessed(const GURL& manifest_url, 2278 void WebContentsImpl::OnAppCacheAccessed(const GURL& manifest_url,
2278 bool blocked_by_policy) { 2279 bool blocked_by_policy) {
2279 // Notify observers about navigation. 2280 // Notify observers about navigation.
2280 FOR_EACH_OBSERVER(WebContentsObserver, observers_, 2281 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2281 AppCacheAccessed(manifest_url, blocked_by_policy)); 2282 AppCacheAccessed(manifest_url, blocked_by_policy));
2282 } 2283 }
2283 2284
2284 void WebContentsImpl::OnOpenColorChooser(int color_chooser_id, 2285 void WebContentsImpl::OnOpenColorChooser(int color_chooser_id,
(...skipping 1109 matching lines...) Expand 10 before | Expand all | Expand 10 after
3394 3395
3395 BrowserPluginGuest* WebContentsImpl::GetBrowserPluginGuest() { 3396 BrowserPluginGuest* WebContentsImpl::GetBrowserPluginGuest() {
3396 return browser_plugin_guest_.get(); 3397 return browser_plugin_guest_.get();
3397 } 3398 }
3398 3399
3399 BrowserPluginEmbedder* WebContentsImpl::GetBrowserPluginEmbedder() { 3400 BrowserPluginEmbedder* WebContentsImpl::GetBrowserPluginEmbedder() {
3400 return browser_plugin_embedder_.get(); 3401 return browser_plugin_embedder_.get();
3401 } 3402 }
3402 3403
3403 } // namespace content 3404 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698