Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: net/quic/quic_connection_test.cc

Issue 11820005: Largest received -> largest observed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_framer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection_test.cc
diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc
index a4ce7fe71c2c58ba83a9f4ee53614c3eb8e50fa6..9bff3ec548bff6b62e59d4d2a90d6009353f2337 100644
--- a/net/quic/quic_connection_test.cc
+++ b/net/quic/quic_connection_test.cc
@@ -352,73 +352,73 @@ class QuicConnectionTest : public ::testing::Test {
TEST_F(QuicConnectionTest, PacketsInOrder) {
ProcessPacket(1);
- EXPECT_EQ(1u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(1u, last_ack()->received_info.largest_observed);
EXPECT_EQ(0u, last_ack()->received_info.missing_packets.size());
ProcessPacket(2);
- EXPECT_EQ(2u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(2u, last_ack()->received_info.largest_observed);
EXPECT_EQ(0u, last_ack()->received_info.missing_packets.size());
ProcessPacket(3);
- EXPECT_EQ(3u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(3u, last_ack()->received_info.largest_observed);
EXPECT_EQ(0u, last_ack()->received_info.missing_packets.size());
}
TEST_F(QuicConnectionTest, PacketsRejected) {
ProcessPacket(1);
- EXPECT_EQ(1u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(1u, last_ack()->received_info.largest_observed);
EXPECT_EQ(0u, last_ack()->received_info.missing_packets.size());
accept_packet_ = false;
ProcessPacket(2);
// We should not have an ack for two.
- EXPECT_EQ(1u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(1u, last_ack()->received_info.largest_observed);
EXPECT_EQ(0u, last_ack()->received_info.missing_packets.size());
}
TEST_F(QuicConnectionTest, PacketsOutOfOrder) {
ProcessPacket(3);
- EXPECT_EQ(3u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(3u, last_ack()->received_info.largest_observed);
EXPECT_TRUE(IsMissing(2));
EXPECT_TRUE(IsMissing(1));
ProcessPacket(2);
- EXPECT_EQ(3u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(3u, last_ack()->received_info.largest_observed);
EXPECT_FALSE(IsMissing(2));
EXPECT_TRUE(IsMissing(1));
ProcessPacket(1);
- EXPECT_EQ(3u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(3u, last_ack()->received_info.largest_observed);
EXPECT_FALSE(IsMissing(2));
EXPECT_FALSE(IsMissing(1));
}
TEST_F(QuicConnectionTest, DuplicatePacket) {
ProcessPacket(3);
- EXPECT_EQ(3u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(3u, last_ack()->received_info.largest_observed);
EXPECT_TRUE(IsMissing(2));
EXPECT_TRUE(IsMissing(1));
// Send packet 3 again, but do not set the expectation that
// the visitor OnPacket() will be called.
ProcessDataPacket(3, 0);
- EXPECT_EQ(3u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(3u, last_ack()->received_info.largest_observed);
EXPECT_TRUE(IsMissing(2));
EXPECT_TRUE(IsMissing(1));
}
TEST_F(QuicConnectionTest, PacketsOutOfOrderWithAdditionsAndLeastAwaiting) {
ProcessPacket(3);
- EXPECT_EQ(3u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(3u, last_ack()->received_info.largest_observed);
EXPECT_TRUE(IsMissing(2));
EXPECT_TRUE(IsMissing(1));
ProcessPacket(2);
- EXPECT_EQ(3u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(3u, last_ack()->received_info.largest_observed);
EXPECT_TRUE(IsMissing(1));
ProcessPacket(5);
- EXPECT_EQ(5u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(5u, last_ack()->received_info.largest_observed);
EXPECT_TRUE(IsMissing(1));
EXPECT_TRUE(IsMissing(4));
@@ -441,7 +441,7 @@ TEST_F(QuicConnectionTest, RejectPacketTooFarOut) {
ProcessDataPacket(6000, 0);
SendAckPacketToPeer(); // Packet 2
- EXPECT_EQ(0u, last_ack()->received_info.largest_received);
+ EXPECT_EQ(0u, last_ack()->received_info.largest_observed);
}
TEST_F(QuicConnectionTest, TruncatedAck) {
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_framer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698