Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: net/quic/quic_connection.cc

Issue 11820005: Largest received -> largest observed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/congestion_control/quic_send_scheduler_test.cc ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index 629863d73f52d9b19d47979c95e78f20187e03e4..e937810ce4291f8f77cabf4bd251a0f2afa04905 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -92,7 +92,7 @@ QuicConnection::QuicConnection(QuicGuid guid,
framer_.set_visitor(this);
memset(&last_header_, 0, sizeof(last_header_));
outgoing_ack_.sent_info.least_unacked = 0;
- outgoing_ack_.received_info.largest_received = 0;
+ outgoing_ack_.received_info.largest_observed = 0;
/*
if (FLAGS_fake_packet_loss_percentage > 0) {
@@ -207,10 +207,10 @@ void QuicConnection::OnCongestionFeedbackFrame(
}
bool QuicConnection::ValidateAckFrame(const QuicAckFrame& incoming_ack) {
- if (incoming_ack.received_info.largest_received >
+ if (incoming_ack.received_info.largest_observed >
packet_creator_.sequence_number()) {
- DLOG(ERROR) << "Client acked unsent packet:"
- << incoming_ack.received_info.largest_received << " vs "
+ DLOG(ERROR) << "Client observed unsent packet:"
+ << incoming_ack.received_info.largest_observed << " vs "
<< packet_creator_.sequence_number();
// We got an error for data we have not sent. Error out.
return false;
@@ -246,10 +246,10 @@ void QuicConnection::UpdatePacketInformationReceivedByPeer(
QuicConnectionVisitorInterface::AckedPackets acked_packets;
// Initialize the lowest unacked packet to the lower of the next outgoing
- // sequence number and the largest received packed in the incoming ack.
+ // sequence number and the largest observed packet in the incoming ack.
QuicPacketSequenceNumber lowest_unacked = min(
packet_creator_.sequence_number() + 1,
- incoming_ack.received_info.largest_received + 1);
+ incoming_ack.received_info.largest_observed + 1);
int resent_packets = 0;
@@ -286,7 +286,7 @@ void QuicConnection::UpdatePacketInformationReceivedByPeer(
// Determine if this packet is being explicitly nacked and, if so, if it
// is worth resending.
QuicPacketSequenceNumber resend_number = 0;
- if (it->first < incoming_ack.received_info.largest_received) {
+ if (it->first < incoming_ack.received_info.largest_observed) {
// The peer got packets after this sequence number. This is an explicit
// nack.
++(it->second.number_nacks);
« no previous file with comments | « net/quic/congestion_control/quic_send_scheduler_test.cc ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698