Add support for getters, setters and constructors in declarations of classMirrors.

reflectable/lib/src/mirrors_unimpl.dart

 // Copyright (c) 2015, the Dart Team. All rights reserved. Use of this
 // source code is governed by a BSD-style license that can be found in
 // the LICENSE file.
 
 import '../mirrors.dart';
 import 'encoding_constants.dart' as constants;
 export 'dart:collection' show UnmodifiableMapView;
 export '../capability.dart';
 export '../static_reflectable.dart';
 
@@ skipping 128 matching lines @@
     implements TypedefMirror {
   FunctionTypeMirror get referent => _unsupported();
 }
 
 abstract class MethodMirrorUnimpl extends DeclarationMirrorUnimpl
     implements MethodMirror {
   TypeMirror get returnType => _unsupported();
   String get source => _unsupported();
   List<ParameterMirror> get parameters => _unsupported();
   bool get isStatic => _unsupported();
-  bool get isAbstract => _unsupported();
+  // We do not support reflection on abstract methods.

[eernst, 2015/06/18 10:07:18]

Let's include abstract methods even though dart:mirrors doesn't. Then we'll keep
track of the cases that don't work in pre-transform form by putting them in
.status (as opposed to spending time on fixing them in any way), and as an bonus
document various little glitches in dart:mirrors that may or may not be known.

[sigurdm, 2015/06/18 11:04:03]

Done.

+  bool get isAbstract => false;
   bool get isSynthetic => _unsupported();
   bool get isRegularMethod => _unsupported();
   bool get isOperator => _unsupported();
   bool get isGetter => _unsupported();
   bool get isSetter => _unsupported();
   bool get isConstructor => _unsupported();
   String get constructorName => _unsupported();
   bool get isConstConstructor => _unsupported();
   bool get isGenerativeConstructor => _unsupported();
   bool get isRedirectingConstructor => _unsupported();
   bool get isFactoryConstructor => _unsupported();
   bool operator ==(other) => _unsupported();
   int get hashCode => _unsupported();
 }
 
 class MethodMirrorImpl implements MethodMirror {
   final int descriptor;
   final String name;
   @override
   final DeclarationMirror owner;
 
   const MethodMirrorImpl(this.name, this.descriptor, this.owner);
 
   int get kind => constants.kindFromEncoding(descriptor);
 
   @override
   String get constructorName => name;
 
+  // We do not support reflection on abstract methods.

[eernst, 2015/06/18 10:07:18]

We may then support them after all.

[sigurdm, 2015/06/18 11:04:03]

Done.

   @override
-  bool get isAbstract => 0 != descriptor & constants.abstractAttribute;
+  bool get isAbstract => false;

[eernst, 2015/06/18 10:07:18]

In case we support abstract methods, reverting this line should be sufficient.

[sigurdm, 2015/06/18 11:04:03]

Done.

 
   @override
   bool get isConstConstructor => 0 != descriptor & constants.constAttribute;
 
   @override
-  bool get isConstructor => isGenerativeConstructor ||
-      isFactoryConstructor ||
-      isRedirectingConstructor;
+  bool get isConstructor => isFactoryConstructor || isGenerativeConstructor;
 
   @override
   bool get isFactoryConstructor => kind == constants.factoryConstructor;
 
   @override
   bool get isGenerativeConstructor => kind == constants.generativeConstructor;
 
   @override
   bool get isGetter => kind == constants.getter;
 
   @override
   bool get isOperator => isRegularMethod &&
       ["+", "-", "*", "/", "[", "<", ">", "=", "~", "%"].contains(name[0]);
 
   @override
   bool get isPrivate => 0 != descriptor & constants.privateAttribute;
 
   @override
-  bool get isRedirectingConstructor => kind == constants.redirectingConstructor;
+  bool get isRedirectingConstructor =>
+      0 != descriptor & constants.redirectingConstructor;
 
   @override
   bool get isRegularMethod => kind == constants.method;
 
   @override
   bool get isSetter => kind == constants.setter;
 
   @override
   bool get isStatic => 0 != descriptor & constants.staticAttribute;
 
@@ skipping 17 matching lines @@
 
   @override
   String get qualifiedName => "${owner.qualifiedName}.$name";
 
   // TODO(sigurdm, eernst): implement returnType
   @override
   TypeMirror get returnType => throw new UnimplementedError();
 
   @override
   String get simpleName => isConstructor
-      ? (name == '' ? "$owner.simpleName" : "${owner.simpleName}.$name")
+      ? (name == '' ? "${owner.simpleName}" : "${owner.simpleName}.$name")
       : name;
 
   @override
   String get source => null;
 }
 
 abstract class VariableMirrorUnimpl extends DeclarationMirrorUnimpl
     implements VariableMirror {
   TypeMirror get type => _unsupported();
   bool get isStatic => _unsupported();
@@ skipping 10 matching lines @@
   bool get isNamed => _unsupported();
   bool get hasDefaultValue => _unsupported();
   Object get defaultValue => _unsupported();
 }
 
 abstract class SourceLocationUnimpl {
   int get line => _unsupported();
   int get column => _unsupported();
   Uri get sourceUri => _unsupported();
 }