Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1181983005: Cleanup of unnecessary WebWidgetClient compositor methods (Closed)

Created:
5 years, 6 months ago by jdduke (slow)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup of unnecessary WebWidgetClient compositor methods There are several compositor-specific WebWidgetClient methods that are unused by Blink and implemented by RenderWidget. These methods are only used by RenderWidgetCompositor. Decouple the Blink dependency, making these methods local to content/. The WebWidgetClient methods will be removed in https://codereview.chromium.org/1174273005. BUG=438646 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/491a3f0c88c0fbe40f33f5a7d9fbc585f7614892 Cr-Commit-Position: refs/heads/master@{#334494}

Patch Set 1 #

Patch Set 2 : Fix #

Total comments: 2

Patch Set 3 : Fix order #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -72 lines) Patch
M chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.h View 3 chunks +16 lines, -8 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 8 chunks +53 lines, -57 lines 0 comments Download
M content/renderer/render_widget_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
jdduke (slow)
+sievers for content/. I'll add remaining owners if you think this change is OK.
5 years, 6 months ago (2015-06-12 22:53:42 UTC) #2
no sievers
lgtm https://codereview.chromium.org/1181983005/diff/20001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/1181983005/diff/20001/content/renderer/render_widget.cc#newcode1392 content/renderer/render_widget.cc:1392: FlushPendingInputEventAck(); Should that happen after calling the observers ...
5 years, 6 months ago (2015-06-15 18:04:08 UTC) #3
jdduke (slow)
+enne for cc/trees +asargent for chrome/extensions/ https://codereview.chromium.org/1181983005/diff/20001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/1181983005/diff/20001/content/renderer/render_widget.cc#newcode1392 content/renderer/render_widget.cc:1392: FlushPendingInputEventAck(); On 2015/06/15 ...
5 years, 6 months ago (2015-06-15 18:15:18 UTC) #5
asargent_no_longer_on_chrome
chrome/browser/extensions lgtm
5 years, 6 months ago (2015-06-15 18:29:31 UTC) #6
enne (OOO)
cc lgtm
5 years, 6 months ago (2015-06-15 18:36:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181983005/40001
5 years, 6 months ago (2015-06-15 20:01:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/63143) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-06-15 20:06:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181983005/60001
5 years, 6 months ago (2015-06-15 22:06:10 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-15 23:30:37 UTC) #16
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/491a3f0c88c0fbe40f33f5a7d9fbc585f7614892 Cr-Commit-Position: refs/heads/master@{#334494}
5 years, 6 months ago (2015-06-15 23:31:46 UTC) #17
mithro-old
5 years, 6 months ago (2015-06-23 09:16:56 UTC) #18
Message was sent while issue was closed.
On 2015/06/15 23:31:46, commit-bot: I haz the power wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/491a3f0c88c0fbe40f33f5a7d9fbc585f7614892
> Cr-Commit-Position: refs/heads/master@{#334494}

Late LGTM - Thanks for doing this clean up!

Powered by Google App Engine
This is Rietveld 408576698