Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: content/renderer/render_widget.h

Issue 1181983005: Cleanup of unnecessary WebWidgetClient compositor methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index ef3e9d1442045616e51ab6a763fe2160683d7202..0fd581c5c6843f1fe04c8833f754ac95482d5bb8 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -166,14 +166,9 @@ class CONTENT_EXPORT RenderWidget
bool Send(IPC::Message* msg) override;
// blink::WebWidgetClient
- virtual void willBeginCompositorFrame();
virtual void didAutoResize(const blink::WebSize& new_size);
virtual void initializeLayerTreeView();
virtual blink::WebLayerTreeView* layerTreeView();
- virtual void didBecomeReadyForAdditionalInput();
- virtual void didCommitAndDrawCompositorFrame();
- virtual void didCompleteSwapBuffers();
- virtual void scheduleComposite();
virtual void didFocus();
virtual void didBlur();
virtual void didChangeCursor(const blink::WebCursorInfo&);
@@ -242,9 +237,6 @@ class CONTENT_EXPORT RenderWidget
// Close the underlying WebWidget.
virtual void Close();
- // Notifies about a compositor frame commit operation having finished.
- virtual void DidCommitCompositorFrame();
-
// Deliveres |message| together with compositor state change updates. The
// exact behavior depends on |policy|.
// This mechanism is not a drop-in replacement for IPC: messages sent this way
@@ -285,6 +277,22 @@ class CONTENT_EXPORT RenderWidget
void SetPopupOriginAdjustmentsForEmulation(ScreenMetricsEmulator* emulator);
gfx::Rect AdjustValidationMessageAnchor(const gfx::Rect& anchor);
+ // Indicates that the compositor is about to begin a frame. This is primarily
+ // to signal to flow control mechanisms that a frame is beginning, not to
+ // perform actual painting work.
+ void WillBeginCompositorFrame();
+
+ // Notifies about a compositor frame commit operation having finished.
+ virtual void DidCommitCompositorFrame();
+
+ // Notifies that the draw commands for a committed frame have been issued.
+ void DidCommitAndDrawCompositorFrame();
+
+ // Notifies that the compositor has posted a swapbuffers operation to the GPU
+ // process.
+ void DidCompleteSwapBuffers();
+
+ void ScheduleComposite();
void ScheduleCompositeWithForcedRedraw();
// Called by the compositor in single-threaded mode when a swap is posted,
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698