Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: tools/dom/scripts/systemnative.py

Issue 11819034: No need in require_v8_scope flag any more. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/systemnative.py
diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py
index ca6789f8c7278f35b885432ae2a4aec9c2a5ae6a..acf4685cf391cc35eb1b0c39cdbdf912f1bdf443 100644
--- a/tools/dom/scripts/systemnative.py
+++ b/tools/dom/scripts/systemnative.py
@@ -543,9 +543,6 @@ class DartiumBackend(HtmlDartGenerator):
ext_attrs = node.ext_attrs
cpp_arguments = []
- requires_v8_scope = \
- any((self._TypeInfo(argument.type.id).requires_v8_scope() for argument in arguments)) or\
- self._interface.id.startswith('IDB')
runtime_check = None
raises_exceptions = raises_dom_exception or arguments
@@ -553,7 +550,6 @@ class DartiumBackend(HtmlDartGenerator):
requires_stack_info = ext_attrs.get('CallWith') == 'ScriptArguments|ScriptState'
if requires_stack_info:
raises_exceptions = True
- requires_v8_scope = True
cpp_arguments = ['&state', 'scriptArguments.release()']
# WebKit uses scriptArguments to reconstruct last argument, so
# it's not needed and should be just removed.
@@ -563,7 +559,6 @@ class DartiumBackend(HtmlDartGenerator):
requires_script_arguments = ext_attrs.get('CallWith') == 'ScriptArguments'
if requires_script_arguments:
raises_exceptions = True
- requires_v8_scope = True
cpp_arguments = ['scriptArguments.release()']
# WebKit uses scriptArguments to reconstruct last argument, so
# it's not needed and should be just removed.
@@ -641,10 +636,6 @@ class DartiumBackend(HtmlDartGenerator):
' return;\n'
' }\n')
- if requires_v8_scope:
- body_emitter.Emit(
- ' V8Scope v8scope;\n\n')
-
if runtime_check:
body_emitter.Emit(
'$RUNTIME_CHECK\n',
« no previous file with comments | « tools/dom/scripts/generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698