Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tools/dom/scripts/generator.py

Issue 11819034: No need in require_v8_scope flag any more. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/dom/scripts/systemnative.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/generator.py
diff --git a/tools/dom/scripts/generator.py b/tools/dom/scripts/generator.py
index ca5e5399206433c7e53d7c43680ccf66f3058675..9ebd03a02f621799aa61ea770c3317c595f4abe8 100644
--- a/tools/dom/scripts/generator.py
+++ b/tools/dom/scripts/generator.py
@@ -813,9 +813,6 @@ class IDLTypeInfo(object):
def vector_to_dart_template_parameter(self):
return self.bindings_class()
- def requires_v8_scope(self):
- return self._data.requires_v8_scope
-
def to_native_info(self, idl_node, interface_name):
cls = self.bindings_class()
@@ -1084,7 +1081,6 @@ class TypeData(object):
conversion_includes=None,
webcore_getter_name='getAttribute',
webcore_setter_name='setAttribute',
- requires_v8_scope=False,
item_type=None, suppress_interface=False, is_typed_array=False):
self.clazz = clazz
self.dart_type = dart_type
@@ -1096,7 +1092,6 @@ class TypeData(object):
self.conversion_includes = conversion_includes
self.webcore_getter_name = webcore_getter_name
self.webcore_setter_name = webcore_setter_name
- self.requires_v8_scope = requires_v8_scope
self.item_type = item_type
self.suppress_interface = suppress_interface
self.is_typed_array = is_typed_array
@@ -1130,7 +1125,7 @@ _idl_type_registry = {
'float': TypeData(clazz='Primitive', dart_type='num', native_type='double'),
'double': TypeData(clazz='Primitive', dart_type='num'),
- 'any': TypeData(clazz='Primitive', dart_type='Object', native_type='ScriptValue', requires_v8_scope=True),
+ 'any': TypeData(clazz='Primitive', dart_type='Object', native_type='ScriptValue'),
'Array': TypeData(clazz='Primitive', dart_type='List'),
'custom': TypeData(clazz='Primitive', dart_type='dynamic'),
'Date': TypeData(clazz='Primitive', dart_type='Date', native_type='double'),
@@ -1138,7 +1133,7 @@ _idl_type_registry = {
'DOMString': TypeData(clazz='Primitive', dart_type='String', native_type='String'),
# TODO(vsm): This won't actually work until we convert the Map to
# a native JS Map for JS DOM.
- 'Dictionary': TypeData(clazz='Primitive', dart_type='Map', requires_v8_scope=True),
+ 'Dictionary': TypeData(clazz='Primitive', dart_type='Map'),
# TODO(sra): Flags is really a dictionary: {create:bool, exclusive:bool}
# http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#the-flags-interface
'Flags': TypeData(clazz='Primitive', dart_type='Object'),
« no previous file with comments | « no previous file | tools/dom/scripts/systemnative.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698