|
|
Revert 175822
After more investigation of what it would take to share the webui code framework from chrome with content, it didn't seam feasible to do this. The code in chrome (i.e. ChromeURLDataManager) is heavily tied to chrome, and is used by chrome for non-webui stuff. The JS code is also specific to Chrome. It seems better to not bring in all this stuff to content.
> Allow multiple WebUIControllerFactory objects to be registered. This makes is possible to implement webui inside content.
> Review URL: https://codereview.chromium.org/11783038
TBR=jam@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175890
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+255 lines, -262 lines) |
Patch |
 |
M |
chrome/browser/chrome_browser_main.cc
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chrome_content_browser_client.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chrome_content_browser_client.cc
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/debugger/debugger_api.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
|
View
|
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/common/chrome_content_client.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/chrome_content_client.cc
|
View
|
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/chrome_content_client_ios.mm
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/test/base/chrome_test_suite.cc
|
View
|
|
2 chunks |
+0 lines, -12 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_process_host_impl.cc
|
View
|
|
4 chunks |
+10 lines, -6 lines |
0 comments
|
Download
|
|
M |
content/browser/site_instance_impl_unittest.cc
|
View
|
|
6 chunks |
+21 lines, -6 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/render_view_host_manager.cc
|
View
|
|
5 chunks |
+24 lines, -20 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/render_view_host_manager_unittest.cc
|
View
|
|
7 chunks |
+50 lines, -9 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/web_contents_impl.cc
|
View
|
|
5 chunks |
+17 lines, -7 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/web_contents_impl_unittest.cc
|
View
|
|
9 chunks |
+48 lines, -18 lines |
0 comments
|
Download
|
|
D |
content/browser/webui/web_ui_controller_factory_registry.h
|
View
|
|
1 chunk |
+0 lines, -47 lines |
0 comments
|
Download
|
|
D |
content/browser/webui/web_ui_controller_factory_registry.cc
|
View
|
|
1 chunk |
+0 lines, -97 lines |
0 comments
|
Download
|
|
M |
content/browser/webui/web_ui_impl.cc
|
View
|
|
2 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/content_browser.gypi
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/public/browser/content_browser_client.h
|
View
|
|
3 chunks |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/public/browser/content_browser_client.cc
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/public/browser/web_ui_controller_factory.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/public/common/content_client.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/public/common/content_client.cc
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/public/common/url_constants.h
|
View
|
|
2 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
content/public/common/url_constants.cc
|
View
|
|
2 chunks |
+0 lines, -10 lines |
0 comments
|
Download
|
|
M |
content/renderer/render_view_browsertest.cc
|
View
|
|
4 chunks |
+35 lines, -4 lines |
0 comments
|
Download
|
|
M |
content/renderer/render_view_impl.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
Total messages: 1 (0 generated)
|
Chromium Code Reviews
Issue
11818036:
Revert 175822 (Closed)
