Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11783038: Allow multiple WebUIControllerFactory objects to be registered. This makes is possible to implement… (Closed)

Created:
7 years, 11 months ago by jam
Modified:
7 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, creis+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, ajwong+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Allow multiple WebUIControllerFactory objects to be registered. This makes is possible to implement webui inside content. BUG=169170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175822 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179107

Patch Set 1 #

Patch Set 2 : fix ios and browser tests build error #

Patch Set 3 : fix unittests #

Patch Set 4 : fix ios again #

Patch Set 5 : better fix for unittests that doesn't interfere with browser_tests #

Patch Set 6 : better fix for unittests that doesn't interfere with browser_tests #

Patch Set 7 : reland after bogus revert of r175971 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -260 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/devtools/devtools_file_helper.cc View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 3 4 5 6 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/chrome_content_client_ios.mm View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 2 3 4 5 6 2 chunks +12 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 4 chunks +6 lines, -10 lines 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 1 2 3 4 5 6 6 chunks +6 lines, -21 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager.cc View 1 2 3 4 5 6 5 chunks +20 lines, -24 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager_unittest.cc View 1 2 3 4 5 6 7 chunks +9 lines, -50 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 5 chunks +7 lines, -17 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 2 3 4 5 6 9 chunks +18 lines, -48 lines 0 comments Download
A content/browser/webui/web_ui_controller_factory_registry.h View 1 chunk +47 lines, -0 lines 0 comments Download
A content/browser/webui/web_ui_controller_factory_registry.cc View 1 chunk +97 lines, -0 lines 0 comments Download
M content/browser/webui/web_ui_impl.cc View 1 2 3 4 5 6 2 chunks +3 lines, -6 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 5 6 3 chunks +0 lines, -7 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/browser/web_ui_controller_factory.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_client.h View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_client.cc View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/url_constants.h View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/common/url_constants.cc View 1 2 3 4 5 6 2 chunks +10 lines, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 4 5 6 4 chunks +4 lines, -35 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
This is something I wanted to do originally but didn't have a chance. We really ...
7 years, 11 months ago (2013-01-08 21:27:31 UTC) #1
Avi (use Gerrit)
7 years, 11 months ago (2013-01-08 21:42:53 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698