Move auth-error reporting code out of SyncGlobalError and into SigninGlobalError

chrome/browser/sync/profile_sync_service_harness.cc

Index: chrome/browser/sync/profile_sync_service_harness.cc
diff --git a/chrome/browser/sync/profile_sync_service_harness.cc b/chrome/browser/sync/profile_sync_service_harness.cc
index 45cd86e1dd9697499135b2d4295cb744e235a19b..7b5d337a3beb0bb90df2c76a579f91c2a710280b 100644
--- a/chrome/browser/sync/profile_sync_service_harness.cc
+++ b/chrome/browser/sync/profile_sync_service_harness.cc
@@ -121,7 +121,10 @@ ProfileSyncServiceHarness::ProfileSyncServiceHarness(
   }
 }
 
-ProfileSyncServiceHarness::~ProfileSyncServiceHarness() {}
+ProfileSyncServiceHarness::~ProfileSyncServiceHarness() {
+  if (service_->HasObserver(this))
+    service_->RemoveObserver(this);
+}

[Roger Tawa OOO till Jul 10th, 2013/01/14 16:06:52]

How is this affected by the rest of this CL?

[Andrew T Wilson (Slow), 2013/01/15 13:24:56]

The problem is ProfileSyncService::ShutdownImpl() can now result in notifying
observers, in the case that there's an auth error (this is a side-effect of
calling UpdateAuthError() to clear our auth error if sync is disabled/signed
out).

ProfileSyncServiceHarness is not always careful to remove itself as an observer
(it adds itself in the constructor, and doesn't remove itself) - this would lead
to crashes in tests when ProfileSyncService notified observers during shutdown.
So I added this to ProfileSyncServiceHarness so it doesn't leave dangling
references to itself in the observer list any longer.

 
 // static
 ProfileSyncServiceHarness* ProfileSyncServiceHarness::CreateAndAttach(