Move auth-error reporting code out of SyncGlobalError and into SigninGlobalError

chrome/browser/sync/profile_sync_service.h

Index: chrome/browser/sync/profile_sync_service.h
diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h
index feca8f77a05f9d71045feea43dc2b92dc5feacfb..8d873eb6626c4aaf72beddfa11dbefb30b681dce 100644
--- a/chrome/browser/sync/profile_sync_service.h
+++ b/chrome/browser/sync/profile_sync_service.h
@@ -21,6 +21,7 @@
 #include "chrome/browser/api/sync/profile_sync_service_base.h"
 #include "chrome/browser/api/sync/profile_sync_service_observer.h"
 #include "chrome/browser/profiles/profile_keyed_service.h"
+#include "chrome/browser/signin/signin_global_error.h"
 #include "chrome/browser/sync/backend_unrecoverable_error_handler.h"
 #include "chrome/browser/sync/failed_datatypes_handler.h"
 #include "chrome/browser/sync/glue/data_type_controller.h"
@@ -155,6 +156,7 @@ class ProfileSyncService : public ProfileSyncServiceBase,
                            public browser_sync::SyncFrontend,
                            public browser_sync::SyncPrefObserver,
                            public browser_sync::DataTypeManagerObserver,
+                           public SigninGlobalError::AuthStatusProvider,
                            public syncer::UnrecoverableErrorHandler,
                            public content::NotificationObserver,
                            public ProfileKeyedService,
@@ -402,6 +404,9 @@ class ProfileSyncService : public ProfileSyncServiceBase,
   // management. If so, the user is not allowed to configure sync.
   bool IsManaged() const;
 
+  // SigninGlobalError::AuthStatusProvider implementation.
+  virtual GoogleServiceAuthError GetAuthStatus() const OVERRIDE;

[tim (not reviewing), 2013/01/15 04:25:42]

Hmm.. we have this and GetAuthError() on this class now :/  How does one tell
the difference?  Can we maybe add more detail to the name of this method in the
interface?

[Andrew T Wilson (Slow), 2013/01/15 13:24:56]

In general, I don't think that the existence of a similar API in a downstream
class should impact the naming of an upstream API. I don't think that
AuthStatusProvider::GetAuthStatus() is unclear, in and of itself (I think it's
pretty clear that it gets the current authenticated status of that provider and
if you were reviewing that API in the absence of your knowledge of
ProfileSyncService you'd have no objections), so I'm not sure why we would
rename it.

That said, if you have a suggestion you find acceptable, I'm happy to rename it
- just let me know. I'm not too concerned about confusion since GetAuthStatus()
and GetAuthError() are basically interchangeable anyway.

Another alternative is for me to get rid of GetAuthError() entirely.

Anyhow, let me know what you'd like to do here.

+
   // syncer::UnrecoverableErrorHandler implementation.
   virtual void OnUnrecoverableError(
       const tracked_objects::Location& from_here,